From 8f8264032dbf8667b0792f683b1221a74cf8e4bf Mon Sep 17 00:00:00 2001 From: Yanqin Jin Date: Fri, 25 Sep 2020 16:43:23 -0700 Subject: [PATCH] Re-add extra compiler flags when building unittests (#7437) Summary: Re-add extra_compiler_flags when building unit tests for fbcode. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7437 Test Plan: Integrate with buck and run internal tests. Reviewed By: pdillinger Differential Revision: D23943924 Pulled By: riversand963 fbshipit-source-id: b92b7ad003e06e0860c45efc5f7f9684233d0c55 --- .gitignore | 1 + TARGETS | 2 +- buckifier/targets_cfg.py | 2 +- 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.gitignore b/.gitignore index f731f4f93..f070cc64a 100644 --- a/.gitignore +++ b/.gitignore @@ -53,6 +53,7 @@ db_test2 trace_analyzer trace_analyzer_test block_cache_trace_analyzer +io_tracer_parser .DS_Store .vs .vscode diff --git a/TARGETS b/TARGETS index f561bfb73..7ae4cd477 100644 --- a/TARGETS +++ b/TARGETS @@ -1722,7 +1722,7 @@ ROCKS_TESTS = [ srcs = [test_cc], arch_preprocessor_flags = ROCKSDB_ARCH_PREPROCESSOR_FLAGS, os_preprocessor_flags = ROCKSDB_OS_PREPROCESSOR_FLAGS, - compiler_flags = ROCKSDB_COMPILER_FLAGS, + compiler_flags = ROCKSDB_COMPILER_FLAGS + extra_compiler_flags, preprocessor_flags = ROCKSDB_PREPROCESSOR_FLAGS, deps = [":rocksdb_test_lib"] + extra_deps, external_deps = ROCKSDB_EXTERNAL_DEPS + [ diff --git a/buckifier/targets_cfg.py b/buckifier/targets_cfg.py index 110842312..68912d113 100644 --- a/buckifier/targets_cfg.py +++ b/buckifier/targets_cfg.py @@ -199,7 +199,7 @@ ROCKS_TESTS = [ srcs = [test_cc], arch_preprocessor_flags = ROCKSDB_ARCH_PREPROCESSOR_FLAGS, os_preprocessor_flags = ROCKSDB_OS_PREPROCESSOR_FLAGS, - compiler_flags = ROCKSDB_COMPILER_FLAGS, + compiler_flags = ROCKSDB_COMPILER_FLAGS + extra_compiler_flags, preprocessor_flags = ROCKSDB_PREPROCESSOR_FLAGS, deps = [":rocksdb_test_lib"] + extra_deps, external_deps = ROCKSDB_EXTERNAL_DEPS + [