From ef390164244b14d3cecdd87dde1ff2404a6ae86b Mon Sep 17 00:00:00 2001 From: fyrz Date: Fri, 9 Jan 2015 09:22:49 +0100 Subject: [PATCH] Fixed memory issue in c_simple_example Valgrind report prior to this fix: ==20829== Memcheck, a memory error detector ==20829== Copyright (C) 2002-2013, and GNU GPL'd, by Julian Seward et al. ==20829== Using Valgrind-3.10.0.SVN and LibVEX; rerun with -h for copyright info ==20829== Command: ./c_simple_example ==20829== ==20829== Invalid read of size 1 ==20829== at 0x4C2F1C8: strcmp (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==20829== by 0x422522: main (in /home/user/rocksgit/transfer/rocksdb-git/examples/c_simple_example) ==20829== Address 0x5f60df5 is 0 bytes after a block of size 5 alloc'd ==20829== at 0x4C2AB80: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==20829== by 0x4226D5: CopyString (c.cc:498) ==20829== by 0x423032: rocksdb_get (c.cc:730) ==20829== by 0x4224EB: main (in /home/user/rocksgit/transfer/rocksdb-git/examples/c_simple_example) ==20829== ==20829== ==20829== HEAP SUMMARY: ==20829== in use at exit: 77 bytes in 5 blocks ==20829== total heap usage: 4,491 allocs, 4,486 frees, 839,216 bytes allocated ==20829== ==20829== LEAK SUMMARY: ==20829== definitely lost: 5 bytes in 1 blocks ==20829== indirectly lost: 0 bytes in 0 blocks ==20829== possibly lost: 0 bytes in 0 blocks ==20829== still reachable: 72 bytes in 4 blocks ==20829== suppressed: 0 bytes in 0 blocks ==20829== Rerun with --leak-check=full to see details of leaked memory ==20829== ==20829== For counts of detected and suppressed errors, rerun with: -v ==20829== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 0 from 0) --- examples/c_simple_example.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/c_simple_example.c b/examples/c_simple_example.c index 8c6f89e39..2a467fb4e 100644 --- a/examples/c_simple_example.c +++ b/examples/c_simple_example.c @@ -30,7 +30,7 @@ int main(int argc, char **argv) { const char key[] = "key"; const char *value = "value"; rocksdb_put(db, writeoptions, key, strlen (key), value, \ - strlen (value), &err); + strlen (value) + 1, &err); assert(!err); // Get value rocksdb_readoptions_t *readoptions = rocksdb_readoptions_create();