diff --git a/build_tools/check-sources.sh b/build_tools/check-sources.sh index 588817588..fdd40a182 100755 --- a/build_tools/check-sources.sh +++ b/build_tools/check-sources.sh @@ -5,25 +5,25 @@ BAD="" -git grep 'namespace rocksdb' -- '*.[ch]*' +git grep -n 'namespace rocksdb' -- '*.[ch]*' if [ "$?" != "1" ]; then echo "^^^^^ Do not hardcode namespace rocksdb. Use ROCKSDB_NAMESPACE" BAD=1 fi -git grep -i 'nocommit' -- ':!build_tools/check-sources.sh' +git grep -n -i 'nocommit' -- ':!build_tools/check-sources.sh' if [ "$?" != "1" ]; then echo "^^^^^ Code was not intended to be committed" BAD=1 fi -git grep '(CalcAvg(throughput_ops_)), static_cast(CalcConfidence95(throughput_ops_)), CalcAvg(throughput_mbs_), CalcConfidence95(throughput_mbs_)); } else { - fprintf(stdout, "%s [AVG %d runs] : %d (± %d) ops/sec\n", name, num_runs, - static_cast(CalcAvg(throughput_ops_)), + fprintf(stdout, "%s [AVG %d runs] : %d (\xC2\xB1 %d) ops/sec\n", name, + num_runs, static_cast(CalcAvg(throughput_ops_)), static_cast(CalcConfidence95(throughput_ops_))); } } @@ -2435,8 +2436,10 @@ class CombinedStats { int num_runs = static_cast(throughput_ops_.size()); if (throughput_mbs_.size() == throughput_ops_.size()) { + // \xC2\xB1 is +/- character in UTF-8 fprintf(stdout, - "%s [AVG %d runs] : %d (± %d) ops/sec; %6.1f (± %.1f) MB/sec\n" + "%s [AVG %d runs] : %d (\xC2\xB1 %d) ops/sec; %6.1f (\xC2\xB1 " + "%.1f) MB/sec\n" "%s [MEDIAN %d runs] : %d ops/sec; %6.1f MB/sec\n", name, num_runs, static_cast(CalcAvg(throughput_ops_)), static_cast(CalcConfidence95(throughput_ops_)), @@ -2445,7 +2448,7 @@ class CombinedStats { CalcMedian(throughput_mbs_)); } else { fprintf(stdout, - "%s [AVG %d runs] : %d (± %d) ops/sec\n" + "%s [AVG %d runs] : %d (\xC2\xB1 %d) ops/sec\n" "%s [MEDIAN %d runs] : %d ops/sec\n", name, num_runs, static_cast(CalcAvg(throughput_ops_)), static_cast(CalcConfidence95(throughput_ops_)), name, diff --git a/util/ribbon_alg.h b/util/ribbon_alg.h index a79952f55..f9afefc23 100644 --- a/util/ribbon_alg.h +++ b/util/ribbon_alg.h @@ -150,7 +150,7 @@ namespace ribbon { // (m/n) than is required with Gaussian elimination. // // Recommended reading: -// "Peeling Close to the Orientability Threshold – Spatial Coupling in +// "Peeling Close to the Orientability Threshold - Spatial Coupling in // Hashing-Based Data Structures" by Stefan Walzer // // ###################################################################### diff --git a/util/xxhash.h b/util/xxhash.h index 9846861b7..706b97bd9 100644 --- a/util/xxhash.h +++ b/util/xxhash.h @@ -13,6 +13,7 @@ #include "port/lang.h" // for FALLTHROUGH_INTENDED, inserted as appropriate /* END RocksDB customizations */ +// clang-format off /* * xxHash - Extremely Fast Hash algorithm * Header File @@ -3673,7 +3674,7 @@ XXH3_initCustomSecret_avx512(void* XXH_RESTRICT customSecret, xxh_u64 seed64) int i; for (i=0; i < nbRounds; ++i) { /* GCC has a bug, _mm512_stream_load_si512 accepts 'void*', not 'void const*', - * this will warn "discards ‘const’ qualifier". */ + * this will warn "discards 'const' qualifier". */ union { XXH_ALIGN(64) const __m512i* cp; XXH_ALIGN(64) void* p;