From 96663410b073bdea26e61d8549427e37a0512e11 Mon Sep 17 00:00:00 2001 From: Yueh-Hsuan Chiang Date: Mon, 23 Jun 2014 17:09:24 -0600 Subject: [PATCH] Fix a rapidjson compile error in mac. Summary: This diff fixes the following compilation error in mac. ./third-party/rapidjson/reader.h:422:31: error: comparison of constant 256 with expression of type 'Ch' (aka 'char') is always true [-Werror,-Wtautological-constant-out-of-range-compare] if ((sizeof(Ch) == 1 || e < 256) && escape[(unsigned char)e]) ~ ^ ~~~ 1 error generated. Test Plan: make db_test Reviewers: haobo, sdong, igor, ljin Reviewed By: ljin Subscribers: leveldb Differential Revision: https://reviews.facebook.net/D19245 --- third-party/rapidjson/reader.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/third-party/rapidjson/reader.h b/third-party/rapidjson/reader.h index 96bbc6eb5..78391add3 100644 --- a/third-party/rapidjson/reader.h +++ b/third-party/rapidjson/reader.h @@ -419,7 +419,7 @@ private: Ch c = s.Take(); if (c == '\\') { // Escape Ch e = s.Take(); - if ((sizeof(Ch) == 1 || e < 256) && escape[(unsigned char)e]) + if ((sizeof(Ch) == 1 || (int)e < 256) && escape[(unsigned char)e]) RAPIDJSON_PUT(escape[(unsigned char)e]); else if (e == 'u') { // Unicode unsigned codepoint = ParseHex4(s);