From 9b8b8b15041cf2f5e02e0a77cb504839f0e20254 Mon Sep 17 00:00:00 2001 From: Peter Dillinger Date: Mon, 7 Mar 2022 15:23:25 -0800 Subject: [PATCH] Remove remaining SKIP_LINK=1 in circleci config (#9669) Summary: Should be unnecessary Pull Request resolved: https://github.com/facebook/rocksdb/pull/9669 Test Plan: CI Reviewed By: ajkr Differential Revision: D34689277 Pulled By: pdillinger fbshipit-source-id: 5d44de1f851503fd1777b869c06c330f3c4deade --- .circleci/config.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index a7ae34e8a..b7fe65019 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -422,7 +422,7 @@ jobs: steps: - pre-steps - run: sudo apt-get update -y && sudo apt-get install gcc-10 g++-10 libgflags-dev - - run: CC=gcc-10 CXX=g++-10 V=1 SKIP_LINK=1 ROCKSDB_CXX_STANDARD=c++20 make -j16 all # Linking broken because libgflags compiled with newer ABI + - run: CC=gcc-10 CXX=g++-10 V=1 ROCKSDB_CXX_STANDARD=c++20 make -j16 all - post-steps build-linux-gcc-11-no_test_run: @@ -433,7 +433,7 @@ jobs: - pre-steps - install-benchmark - run: sudo add-apt-repository -y ppa:ubuntu-toolchain-r/test && sudo apt-get update -y && sudo apt-get install gcc-11 g++-11 libgflags-dev - - run: CC=gcc-11 CXX=g++-11 V=1 SKIP_LINK=1 make -j16 all microbench # Linking broken because libgflags compiled with newer ABI + - run: CC=gcc-11 CXX=g++-11 V=1 make -j16 all microbench - post-steps build-linux-clang-13-no_test_run: