From 9d347332fb2acf418c11314fa9743c9130107226 Mon Sep 17 00:00:00 2001 From: Andrew Kryczka Date: Tue, 12 Jun 2018 13:38:09 -0700 Subject: [PATCH] Fix argument mismatch in BlockBasedTableBuilder (#3974) Summary: The sixth argument should be `key_includes_seq` bool, the seventh a `GetContext*`. We were mistakenly passing the `GetContext*` as the sixth argument and relying on the default (nullptr) for the seventh. This would make statistics inaccurate, at least. Blame: 402b7aa0 Closes https://github.com/facebook/rocksdb/pull/3974 Differential Revision: D8344907 Pulled By: ajkr fbshipit-source-id: 3ad865a0541d6d30f75dfc726352788118cfe12e --- table/block_based_table_reader.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/table/block_based_table_reader.cc b/table/block_based_table_reader.cc index 180bc76e5..0072be6d6 100644 --- a/table/block_based_table_reader.cc +++ b/table/block_based_table_reader.cc @@ -2209,7 +2209,7 @@ Status BlockBasedTable::Get(const ReadOptions& read_options, const Slice& key, } else { BlockIter biter; NewDataBlockIterator(rep_, read_options, iiter->value(), &biter, false, - get_context); + true /* key_includes_seq */, get_context); if (read_options.read_tier == kBlockCacheTier && biter.status().IsIncomplete()) {