From 9db8c4c5563a2e022d8a07b6f889c34c68ae6aef Mon Sep 17 00:00:00 2001 From: Igor Canadi Date: Mon, 10 Mar 2014 14:42:03 -0700 Subject: [PATCH] Fix share_table_files bug Summary: constructor wasn't properly constructing BackupableDBOptions Test Plan: no test Reviewers: benj Reviewed By: benj CC: leveldb Differential Revision: https://reviews.facebook.net/D16749 --- include/utilities/backupable_db.h | 1 + utilities/backupable/backupable_db.cc | 8 +++++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/include/utilities/backupable_db.h b/include/utilities/backupable_db.h index 0fc4ef69f..22a75ac34 100644 --- a/include/utilities/backupable_db.h +++ b/include/utilities/backupable_db.h @@ -64,6 +64,7 @@ struct BackupableDBOptions { bool _destroy_old_data = false) : backup_dir(_backup_dir), backup_env(_backup_env), + share_table_files(_share_table_files), info_log(_info_log), sync(_sync), destroy_old_data(_destroy_old_data) {} diff --git a/utilities/backupable/backupable_db.cc b/utilities/backupable/backupable_db.cc index f46000dfc..63731b69a 100644 --- a/utilities/backupable/backupable_db.cc +++ b/utilities/backupable/backupable_db.cc @@ -29,10 +29,12 @@ namespace rocksdb { void BackupableDBOptions::Dump(Logger* logger) const { Log(logger, " Options.backup_dir: %s", backup_dir.c_str()); Log(logger, " Options.backup_env: %p", backup_env); - Log(logger, "Options.share_table_files: %d", share_table_files); + Log(logger, "Options.share_table_files: %d", + static_cast(share_table_files)); Log(logger, " Options.info_log: %p", info_log); - Log(logger, " Options.sync: %d", sync); - Log(logger, " Options.destroy_old_data: %d", destroy_old_data); + Log(logger, " Options.sync: %d", static_cast(sync)); + Log(logger, " Options.destroy_old_data: %d", + static_cast(destroy_old_data)); } // -------- BackupEngineImpl class ---------