From 9ff569bdfca01761cb30c35eb75c644005084a61 Mon Sep 17 00:00:00 2001 From: Peter Dillinger Date: Thu, 19 Dec 2019 10:22:43 -0800 Subject: [PATCH] Temporarily disable level_compaction_dynamic_level_bytes in crash test (#6217) Summary: We're seeing assertion violations like this in crash test: db_stress: table/block_based/block_based_table_reader.cc:4129: virtual uint64_t rocksdb::BlockBasedTable::ApproximateSize(const rocksdb::Slice&, const rocksdb::Slice&, rocksdb::TableReaderCaller): Assertion `end_offset >= start_offset' failed.*** And ApproximateSize appears only to be called with the level_compaction_dynamic_level_bytes option. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6217 Test Plan: temporarily put an assert(false) in ApproximateSize and briefly run 'make crash_test' Differential Revision: D19179174 Pulled By: pdillinger fbshipit-source-id: 506e6549aea0da19b363a1a6da04373c364d92e4 --- tools/db_crashtest.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/db_crashtest.py b/tools/db_crashtest.py index e2d7f5980..c80c2ea87 100644 --- a/tools/db_crashtest.py +++ b/tools/db_crashtest.py @@ -96,7 +96,9 @@ default_params = { "write_dbid_to_manifest" : random.randint(0, 1), "max_write_batch_group_size_bytes" : lambda: random.choice( [16, 64, 1024 * 1024, 16 * 1024 * 1024]), - "level_compaction_dynamic_level_bytes" : True, + # Temporarily disabled because of assertion violations in + # BlockBasedTable::ApproximateSize + # "level_compaction_dynamic_level_bytes" : True, "verify_checksum_one_in": 1000000 }