From a4d73ddee0e82ca327ec6aaddc1d439b00ea993e Mon Sep 17 00:00:00 2001 From: Igor Canadi Date: Mon, 7 Apr 2014 16:33:03 -0700 Subject: [PATCH] Initialize Options::bloom_locality Summary: I think this issue was caused by bad merge. We have to initialize bloom_locality, otherwise valgrind complains: "Use of uninitialised value of size 8" Test Plan: Run valgrind ./prefix_test Reviewers: ljin Reviewed By: ljin CC: leveldb Differential Revision: https://reviews.facebook.net/D17553 --- util/options.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/util/options.cc b/util/options.cc index 43e265280..56a0d43f1 100644 --- a/util/options.cc +++ b/util/options.cc @@ -79,6 +79,7 @@ ColumnFamilyOptions::ColumnFamilyOptions() inplace_callback(nullptr), memtable_prefix_bloom_bits(0), memtable_prefix_bloom_probes(6), + bloom_locality(0), max_successive_merges(0), min_partial_merge_operands(2) { assert(memtable_factory.get() != nullptr); @@ -143,6 +144,7 @@ ColumnFamilyOptions::ColumnFamilyOptions(const Options& options) inplace_callback(options.inplace_callback), memtable_prefix_bloom_bits(options.memtable_prefix_bloom_bits), memtable_prefix_bloom_probes(options.memtable_prefix_bloom_probes), + bloom_locality(options.bloom_locality), max_successive_merges(options.max_successive_merges), min_partial_merge_operands(options.min_partial_merge_operands) { assert(memtable_factory.get() != nullptr); @@ -421,6 +423,8 @@ void ColumnFamilyOptions::Dump(Logger* log) const { memtable_prefix_bloom_bits); Log(log, " Options.memtable_prefix_bloom_probes: %d", memtable_prefix_bloom_probes); + Log(log, " Options.bloom_locality: %d", + bloom_locality); Log(log, " Options.max_successive_merges: %zd", max_successive_merges); } // ColumnFamilyOptions::Dump