From a984040f0bf205cb102cfbc377f8c9e44aff0300 Mon Sep 17 00:00:00 2001 From: anand76 Date: Thu, 30 May 2019 11:08:35 -0700 Subject: [PATCH] Increase Trash/DB size ratio in DBSSTTest.RateLimitedWALDelete (#5366) Summary: By increasing the ratio, we ensure that all files go through background deletion and eliminate flakiness due to timing of deletions. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5366 Differential Revision: D15549992 Pulled By: anand1976 fbshipit-source-id: d137375cd791fc1a802841412755d6e2b8fd7688 --- db/db_sst_test.cc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/db/db_sst_test.cc b/db/db_sst_test.cc index 815aed23e..799d0e14f 100644 --- a/db/db_sst_test.cc +++ b/db/db_sst_test.cc @@ -430,6 +430,7 @@ TEST_F(DBSSTTest, RateLimitedWALDelete) { env_->time_elapse_only_sleep_ = true; Options options = CurrentOptions(); options.disable_auto_compactions = true; + options.compression = kNoCompression; options.env = env_; int64_t rate_bytes_per_sec = 1024 * 10; // 10 Kbs / Sec @@ -439,7 +440,7 @@ TEST_F(DBSSTTest, RateLimitedWALDelete) { ASSERT_OK(s); options.sst_file_manager->SetDeleteRateBytesPerSecond(rate_bytes_per_sec); auto sfm = static_cast(options.sst_file_manager.get()); - sfm->delete_scheduler()->SetMaxTrashDBRatio(2.1); + sfm->delete_scheduler()->SetMaxTrashDBRatio(3.1); ASSERT_OK(TryReopen(options)); rocksdb::SyncPoint::GetInstance()->EnableProcessing();