From b1a02ffeabb3ad3edceddf31f88c7543f01a03d4 Mon Sep 17 00:00:00 2001 From: Yanqin Jin Date: Mon, 5 Aug 2019 15:40:31 -0700 Subject: [PATCH] Fix make target 'all' and 'check' (#5672) Summary: If a test is one of parallel tests, then it should also be one of the 'tests'. Otherwise, `make all` won't build the binaries. For examle, ``` $COMPILE_WITH_ASAN=1 make -j32 all ``` Then if you do ``` $make check ``` The second command will invoke the compilation and building for db_bloom_test and file_reader_writer_test **without** the `COMPILE_WITH_ASAN=1`, causing the command to fail. Test plan (on devserver): ``` $make -j32 all ``` Verify all binaries are built so that `make check` won't have to compile any thing. Pull Request resolved: https://github.com/facebook/rocksdb/pull/5672 Differential Revision: D16655834 Pulled By: riversand963 fbshipit-source-id: 050131412b5313496f85ae3deeeeb8d28af75746 --- Makefile | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Makefile b/Makefile index fbe6d2d06..4502be8e4 100644 --- a/Makefile +++ b/Makefile @@ -445,6 +445,7 @@ TESTS = \ db_iter_test \ db_iter_stress_test \ db_log_iter_test \ + db_bloom_filter_test \ db_compaction_filter_test \ db_compaction_test \ db_dynamic_level_test \ @@ -479,6 +480,7 @@ TESTS = \ fault_injection_test \ filelock_test \ filename_test \ + file_reader_writer_test \ block_based_filter_block_test \ full_filter_block_test \ partitioned_filter_block_test \