From bf783808515d8afc6ced61ab44c1193d44595345 Mon Sep 17 00:00:00 2001 From: Qiaolin Yu <90088090+Qiaolin-Yu@users.noreply.github.com> Date: Wed, 26 Oct 2022 17:02:37 -0700 Subject: [PATCH] Rename block_cache_trace_analyzer_tool in CMakeLists (#10814) Summary: Currently, the name of `block_cache_trace_analyzer_tool` in `CMakeLists.txt` is somewhat confusing. ## Makefile The same thing in Makefile is called `block_cache_trace_analyzer`. ```c++ block_cache_trace_analyzer: $(OBJ_DIR)/tools/block_cache_analyzer/block_cache_trace_analyzer_tool.o $(ANALYZE_OBJECTS) $(TOOLS_LIBRARY) $(LIBRARY) $(AM_LINK) ``` ## RocksDB Wiki Also, in the [Block-cache-analysis-and-simulation-tools](https://github.com/facebook/rocksdb/wiki/Block-cache-analysis-and-simulation-tools#quick-start) of RocksDB Wiki, it is called `block_cache_trace_analyzer` too. Screen Shot 2022-10-13 at 20 07 09 Therefore, I think maybe it's better to rename `block_cache_trace_analyzer_tool` to `block_cache_trace_analyzer` in `CMakeLists.txt`. Pull Request resolved: https://github.com/facebook/rocksdb/pull/10814 Reviewed By: ajkr Differential Revision: D40348522 Pulled By: jay-zhuang fbshipit-source-id: f3d69d5880b27cdb8c8fe71df56fa3dbe1dc32fb --- CMakeLists.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 61de269f8..7ab54c500 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1573,9 +1573,9 @@ endif() option(WITH_TRACE_TOOLS "build with trace tools" ON) if(WITH_TRACE_TOOLS) - add_executable(block_cache_trace_analyzer_tool${ARTIFACT_SUFFIX} + add_executable(block_cache_trace_analyzer${ARTIFACT_SUFFIX} tools/block_cache_analyzer/block_cache_trace_analyzer_tool.cc) - target_link_libraries(block_cache_trace_analyzer_tool${ARTIFACT_SUFFIX} + target_link_libraries(block_cache_trace_analyzer${ARTIFACT_SUFFIX} ${ROCKSDB_LIB} ${GFLAGS_LIB} ${FOLLY_LIBS}) add_executable(trace_analyzer${ARTIFACT_SUFFIX}