From c234ac9ac91247e3ff94235c39d6af70b4de4c9e Mon Sep 17 00:00:00 2001 From: Hui Xiao Date: Mon, 7 Feb 2022 09:56:30 -0800 Subject: [PATCH] Clarify Google benchmark < 1.6.0 in INSTALL.md (#9505) Summary: **Context:** Google benchmark [v1.6.0](https://github.com/google/benchmark/releases/tag/v1.6.0) introduced a breaking change "`introduce accessorrs for public data members (https://github.com/google/benchmark/pull/1208)`" that will fail RocksDB build of microbench developed based on previous code. For example, https://github.com/facebook/rocksdb/issues/9489. **Summary:** Clarify the maximum version of Google benchmark needed. Pull Request resolved: https://github.com/facebook/rocksdb/pull/9505 Test Plan: CI Reviewed By: ajkr Differential Revision: D34023447 Pulled By: hx235 fbshipit-source-id: 0128ffc31485f2d752ab2116771f6ae53231fcd7 --- INSTALL.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/INSTALL.md b/INSTALL.md index 96ece3d2d..0afba94d3 100644 --- a/INSTALL.md +++ b/INSTALL.md @@ -47,6 +47,8 @@ to build a portable binary, add `PORTABLE=1` before your make commands, like thi * If you wish to build the RocksJava static target, then cmake is required for building Snappy. +* If you wish to run microbench (e.g, `make microbench`, `make ribbon_bench` or `cmake -DWITH_BENCHMARK=1`), Google benchmark < 1.6.0 is needed. + ## Supported platforms * **Linux - Ubuntu**