deflake DBCompactionTestWithParam.IntraL0Compaction test (#7065)
Summary: This check is flaky because compaction could run between the `Flush()` and the `TestGetTickerCount()`, which would increase the `BLOCK_CACHE_INDEX_MISS` count beyond what the test expects. Verified by adding a `sleep(1)` between those two lines and observing the counter is too high every time. The solution is just to remove this check as it doesn't have any use anyways. The latter check of index miss is sufficient to conclude the newest L0 file (i.e., the one generated by intra-L0) does not have its index block pinned in cache. It'd be nice to simultaneously check the L0 files generated by flush do have their index blocks pinned in cache, but that's not what the line deleted in this PR was checking.. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7065 Reviewed By: pdillinger Differential Revision: D22340327 Pulled By: ajkr fbshipit-source-id: e076b2c7228b7fa763dd0c0cb13828e176c1abeemain
parent
e2fd501d44
commit
c25a014792
Loading…
Reference in new issue