From cbe2c6d2d232af66cccb31e0c246846098b2b2a5 Mon Sep 17 00:00:00 2001 From: Mohamed Issa Date: Tue, 23 Aug 2022 16:00:14 -0700 Subject: [PATCH] Remove unnecessary append to PLUGINS variable in top-level CMakeLists.txt (#10494) Summary: The PLUGINS variable already contains a semicolon separated list of plugins to compile, so there is no need to append the space separated list in ROCKSDB_PLUGINS passed in as compile argument. Removing this unnecessary append now allows CMake based compiles for two or more plugins at a time. Pull Request resolved: https://github.com/facebook/rocksdb/pull/10494 Reviewed By: hx235 Differential Revision: D38482094 Pulled By: ajkr fbshipit-source-id: 61565f7cae2717e70a92132c972b25692ce6f0e8 --- CMakeLists.txt | 1 - 1 file changed, 1 deletion(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index bb65a9d8b..42ccd07f1 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -1008,7 +1008,6 @@ endif() set(ROCKSDB_PLUGIN_EXTERNS "") set(ROCKSDB_PLUGIN_BUILTINS "") message(STATUS "ROCKSDB PLUGINS TO BUILD ${ROCKSDB_PLUGINS}") -list(APPEND PLUGINS ${ROCKSDB_PLUGINS}) foreach(PLUGIN IN LISTS PLUGINS) set(PLUGIN_ROOT "${CMAKE_CURRENT_SOURCE_DIR}/plugin/${PLUGIN}/") message("including rocksb plugin ${PLUGIN_ROOT}")