From cdc7ba3a32d6a2f0db3681d0b34cd48a8ac6e636 Mon Sep 17 00:00:00 2001 From: Cheng Chang Date: Fri, 6 Nov 2020 14:21:59 -0800 Subject: [PATCH] DBTablePropertiesTest often times out in internal test infra (#7639) Summary: In this test, after flushing memtable, it will read directly from the sst files, so `env_do_fsync` was `true` to ensure that the flushed sst files can be read afterwards. Considering that the test does not last long, the data should be available in os buffer even without fsync, so this PR tries to disable fsync to reduce test time. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7639 Test Plan: watch the test to pass in internal infra Reviewed By: anand1976 Differential Revision: D24764689 Pulled By: cheng-chang fbshipit-source-id: ef827611a3eaca04201e4280ae801d6c8e60c138 --- db/db_table_properties_test.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/db/db_table_properties_test.cc b/db/db_table_properties_test.cc index 89f36fda5..0cdd5b734 100644 --- a/db/db_table_properties_test.cc +++ b/db/db_table_properties_test.cc @@ -52,7 +52,7 @@ class DBTablePropertiesTest : public DBTestBase, public testing::WithParamInterface { public: DBTablePropertiesTest() - : DBTestBase("/db_table_properties_test", /*env_do_fsync=*/true) {} + : DBTestBase("/db_table_properties_test", /*env_do_fsync=*/false) {} TablePropertiesCollection TestGetPropertiesOfTablesInRange( std::vector ranges, std::size_t* num_properties = nullptr, std::size_t* num_files = nullptr);