diff --git a/util/file_util.cc b/util/file_util.cc index c6323b35b..80376b6df 100644 --- a/util/file_util.cc +++ b/util/file_util.cc @@ -24,39 +24,39 @@ Status CopyFile(Env* env, const std::string& source, { unique_ptr srcfile; - s = env->NewSequentialFile(source, &srcfile, soptions); - unique_ptr destfile; - if (s.ok()) { + s = env->NewSequentialFile(source, &srcfile, soptions); + if (!s.ok()) { + return s; + } + unique_ptr destfile; s = env->NewWritableFile(destination, &destfile, soptions); - } else { - return s; - } + if (!s.ok()) { + return s; + } - if (size == 0) { - // default argument means copy everything - if (s.ok()) { + if (size == 0) { + // default argument means copy everything s = env->GetFileSize(source, &size); - } else { - return s; + if (!s.ok()) { + return s; + } } - } - src_reader.reset(new SequentialFileReader(std::move(srcfile))); - dest_writer.reset(new WritableFileWriter(std::move(destfile), soptions)); + src_reader.reset(new SequentialFileReader(std::move(srcfile))); + dest_writer.reset(new WritableFileWriter(std::move(destfile), soptions)); } char buffer[4096]; Slice slice; while (size > 0) { size_t bytes_to_read = std::min(sizeof(buffer), static_cast(size)); - if (s.ok()) { - s = src_reader->Read(bytes_to_read, &slice, buffer); + s = src_reader->Read(bytes_to_read, &slice, buffer); + if (!s.ok()) { + return s; } - if (s.ok()) { - if (slice.size() == 0) { - return Status::Corruption("file too small"); - } - s = dest_writer->Append(slice); + if (slice.size() == 0) { + return Status::Corruption("file too small"); } + s = dest_writer->Append(slice); if (!s.ok()) { return s; }