From ddb7620a617633f371b090a71254ac5d24f7eb2a Mon Sep 17 00:00:00 2001 From: stefan-zobel Date: Mon, 28 Feb 2022 11:51:17 -0800 Subject: [PATCH] Fix trivial Javadoc omissions (#9534) Summary: - fix spelling of `valueSizeSofLimit` and add "param" description in ReadOptions - add 3 missing "return" in RocksDB Pull Request resolved: https://github.com/facebook/rocksdb/pull/9534 Reviewed By: riversand963 Differential Revision: D34131186 Pulled By: mrambacher fbshipit-source-id: 7eb7ec177906052837180b291d67fb1c838c49e1 --- java/src/main/java/org/rocksdb/ReadOptions.java | 6 +++--- java/src/main/java/org/rocksdb/RocksDB.java | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) mode change 100644 => 100755 java/src/main/java/org/rocksdb/ReadOptions.java diff --git a/java/src/main/java/org/rocksdb/ReadOptions.java b/java/src/main/java/org/rocksdb/ReadOptions.java old mode 100644 new mode 100755 index 32a207966..0836f0f18 --- a/java/src/main/java/org/rocksdb/ReadOptions.java +++ b/java/src/main/java/org/rocksdb/ReadOptions.java @@ -751,12 +751,12 @@ public class ReadOptions extends RocksObject { * * Default: {@code std::numeric_limits::max()} * - * @param valueSizeSofLimit + * @param valueSizeSoftLimit the maximum cumulative value size of the keys * @return the reference to the current ReadOptions */ - public ReadOptions setValueSizeSoftLimit(final long valueSizeSofLimit) { + public ReadOptions setValueSizeSoftLimit(final long valueSizeSoftLimit) { assert (isOwningHandle()); - setValueSizeSoftLimit(nativeHandle_, valueSizeSofLimit); + setValueSizeSoftLimit(nativeHandle_, valueSizeSoftLimit); return this; } diff --git a/java/src/main/java/org/rocksdb/RocksDB.java b/java/src/main/java/org/rocksdb/RocksDB.java index dd8eb9bb7..3bdab157d 100644 --- a/java/src/main/java/org/rocksdb/RocksDB.java +++ b/java/src/main/java/org/rocksdb/RocksDB.java @@ -2296,6 +2296,7 @@ public class RocksDB extends RocksObject { * @throws RocksDBException if error happens in underlying native library. * @throws IllegalArgumentException thrown if the number of passed keys and passed values * do not match. + * @return the list of values for the given list of keys */ public List multiGetByteBuffers(final ReadOptions readOptions, final List keys, final List values) throws RocksDBException { @@ -2318,6 +2319,7 @@ public class RocksDB extends RocksObject { * @throws RocksDBException if error happens in underlying native library. * @throws IllegalArgumentException thrown if the number of passed keys, passed values and * passed column family handles do not match. + * @return the list of values for the given list of keys */ public List multiGetByteBuffers( final List columnFamilyHandleList, final List keys, @@ -2341,6 +2343,7 @@ public class RocksDB extends RocksObject { * @throws RocksDBException if error happens in underlying native library. * @throws IllegalArgumentException thrown if the number of passed keys, passed values and * passed column family handles do not match. + * @return the list of values for the given list of keys */ public List multiGetByteBuffers(final ReadOptions readOptions, final List columnFamilyHandleList, final List keys,