From dde774db646d74054a312878244206431ee939e4 Mon Sep 17 00:00:00 2001 From: Hui Xiao Date: Wed, 18 May 2022 22:25:54 -0700 Subject: [PATCH] Mark old reserve* option deprecated (#10016) Summary: **Context/Summary:** https://github.com/facebook/rocksdb/pull/9926 removed inefficient `reserve*` option API but forgot to mark them deprecated in `block_based_table_type_info` for compatible table format. Pull Request resolved: https://github.com/facebook/rocksdb/pull/10016 Test Plan: build-format-compatible Reviewed By: pdillinger Differential Revision: D36484247 Pulled By: hx235 fbshipit-source-id: c41b90cc99fb7ab7098934052f0af7290b221f98 --- table/block_based/block_based_table_factory.cc | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/table/block_based/block_based_table_factory.cc b/table/block_based/block_based_table_factory.cc index 588c82236..d29855955 100644 --- a/table/block_based/block_based_table_factory.cc +++ b/table/block_based/block_based_table_factory.cc @@ -328,6 +328,12 @@ static std::unordered_map detect_filter_construct_corruption), OptionType::kBoolean, OptionVerificationType::kNormal, OptionTypeFlags::kMutable}}, + {"reserve_table_builder_memory", + {0, OptionType::kBoolean, OptionVerificationType::kDeprecated, + OptionTypeFlags::kNone}}, + {"reserve_table_reader_memory", + {0, OptionType::kBoolean, OptionVerificationType::kDeprecated, + OptionTypeFlags::kNone}}, {"skip_table_builder_flush", {0, OptionType::kBoolean, OptionVerificationType::kDeprecated, OptionTypeFlags::kNone}},