From e0b87afc7041e7c99721dab8522be87570c975e7 Mon Sep 17 00:00:00 2001 From: Siying Dong Date: Thu, 23 Feb 2017 15:54:47 -0800 Subject: [PATCH] Black list some slow valgrind tests Summary: valgrind tests always timeout with parallel run. Black list some slowest ones. It is better to run fewer tests than always have the tests timeout. Closes https://github.com/facebook/rocksdb/pull/1908 Differential Revision: D4607875 Pulled By: siying fbshipit-source-id: 7062664 --- Makefile | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Makefile b/Makefile index a0e083d88..bc8376995 100644 --- a/Makefile +++ b/Makefile @@ -670,6 +670,8 @@ check_0: | grep -E '$(tests-regexp)' \ | build_tools/gnu_parallel -j$(J) --plain --joblog=LOG $$eta --gnu '{} >& t/log-{/}' +valgrind-blacklist-regexp = InlineSkipTest.ConcurrentInsert|TransactionTest.DeadlockStress|DBCompactionTest.SuggestCompactRangeNoTwoLevel0Compactions|BackupableDBTest.RateLimiting|DBTest.CloseSpeedup|DBTest.ThreadStatusFlush|DBTest.RateLimitingTest|DBTest.EncodeDecompressedBlockSizeTest|FaultInjectionTest.UninstalledCompaction|HarnessTest.Randomized|ExternalSSTFileTest.CompactDuringAddFileRandom|ExternalSSTFileTest.IngestFileWithGlobalSeqnoRandomized + .PHONY: valgrind_check_0 valgrind_check_0: $(AM_V_GEN)export TEST_TMPDIR=$(TMPD); \ @@ -683,6 +685,7 @@ valgrind_check_0: } \ | $(prioritize_long_running_tests) \ | grep -E '$(tests-regexp)' \ + | grep -E -v '$(valgrind-blacklist-regexp)' \ | build_tools/gnu_parallel -j$(J) --plain --joblog=LOG $$eta --gnu \ '(if [[ "{}" == "./"* ]] ; then $(DRIVER) {}; else {}; fi) ' \ '>& t/valgrind_log-{/}'