From e3814a860818531fd8a36d3dd908382e21839bf4 Mon Sep 17 00:00:00 2001 From: Andrew Kryczka Date: Thu, 7 Dec 2017 16:09:25 -0800 Subject: [PATCH] revert fbcode build behavior Summary: Closes https://github.com/facebook/rocksdb/pull/3242 Differential Revision: D6514255 Pulled By: ajkr fbshipit-source-id: c39fa8e745866b052649d02bf339e794d77e96a3 --- HISTORY.md | 2 ++ build_tools/fbcode_config.sh | 1 + build_tools/fbcode_config4.8.1.sh | 1 + 3 files changed, 4 insertions(+) diff --git a/HISTORY.md b/HISTORY.md index aa6232afd..bdd452f45 100644 --- a/HISTORY.md +++ b/HISTORY.md @@ -1,6 +1,8 @@ # Rocksdb Change Log ## Unreleased ### Public API Change +* When running `make` with environment variable `USE_SSE` set and `PORTABLE` unset, will use all machine features available locally. Previously this combination only compiled SSE-related features. + ### New Features * Provide lifetime hints when writing files on Linux. This reduces hardware write-amp on storage devices supporting multiple streams. * Add a DB stat, `NUMBER_ITER_SKIP`, which returns how many internal keys were skipped during iterations (e.g., due to being tombstones or duplicate versions of a key). diff --git a/build_tools/fbcode_config.sh b/build_tools/fbcode_config.sh index b8609a11c..af6899296 100644 --- a/build_tools/fbcode_config.sh +++ b/build_tools/fbcode_config.sh @@ -83,6 +83,7 @@ CFLAGS+=" -DTBB" # use Intel SSE support for checksum calculations export USE_SSE=1 +export PORTABLE=1 BINUTILS="$BINUTILS_BASE/bin" AR="$BINUTILS/ar" diff --git a/build_tools/fbcode_config4.8.1.sh b/build_tools/fbcode_config4.8.1.sh index f5b8334db..c40c10131 100644 --- a/build_tools/fbcode_config4.8.1.sh +++ b/build_tools/fbcode_config4.8.1.sh @@ -54,6 +54,7 @@ TBB_LIBS="$TBB_BASE/lib/libtbb.a" # use Intel SSE support for checksum calculations export USE_SSE=1 +export PORTABLE=1 BINUTILS="$BINUTILS_BASE/bin" AR="$BINUTILS/ar"