From e4feb7860678e5c024b067c5309a4687f055973a Mon Sep 17 00:00:00 2001 From: Siying Dong Date: Thu, 3 Jan 2019 10:54:09 -0800 Subject: [PATCH] Try to fix DBSSTTest.RateLimitedDelete flakiness (#4840) Summary: DBSSTTest.RateLimitedDelete is flakey. The root cause is not completely identified, but the compaction waiting in the test doesn't strictly wait for compaction cleaning to finish, which may cause test flakiness. Fix it first and see whether the failures still happen. Pull Request resolved: https://github.com/facebook/rocksdb/pull/4840 Differential Revision: D13567273 Pulled By: siying fbshipit-source-id: 6fce38b912aff92a925231e7aa9bb0fef892761a --- db/db_sst_test.cc | 1 + 1 file changed, 1 insertion(+) diff --git a/db/db_sst_test.cc b/db/db_sst_test.cc index 5cfbd6675..c25ead6e2 100644 --- a/db/db_sst_test.cc +++ b/db/db_sst_test.cc @@ -385,6 +385,7 @@ TEST_F(DBSSTTest, RateLimitedDelete) { // Compaction will move the 4 files in L0 to trash and create 1 L1 file ASSERT_OK(db_->CompactRange(CompactRangeOptions(), nullptr, nullptr)); + ASSERT_OK(dbfull()->TEST_WaitForCompact(true)); ASSERT_EQ("0,1", FilesPerLevel(0)); uint64_t delete_start_time = env_->NowMicros();