From e750dacffba1cb10818baec0ac8351da7697c062 Mon Sep 17 00:00:00 2001 From: Tomas Kolda Date: Sun, 17 Jun 2018 20:54:22 -0700 Subject: [PATCH] Crash on Windows, because of shared_ptr reinterpret cast (#3999) Summary: For more details see #3998 Closes https://github.com/facebook/rocksdb/pull/3999 Differential Revision: D8458905 Pulled By: sagar0 fbshipit-source-id: d6e09182933253a08eaf81ac7cfe50ed3b6576c5 --- java/rocksjni/options.cc | 2 +- java/rocksjni/transaction.cc | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/java/rocksjni/options.cc b/java/rocksjni/options.cc index bd33bc22f..953875306 100644 --- a/java/rocksjni/options.cc +++ b/java/rocksjni/options.cc @@ -3230,7 +3230,7 @@ Java_org_rocksdb_ColumnFamilyOptions_setCompactionFilterFactoryHandle( JNIEnv* /*env*/, jobject /*jobj*/, jlong jopt_handle, jlong jcompactionfilterfactory_handle) { auto* cff_factory = - reinterpret_cast*>( + reinterpret_cast*>( jcompactionfilterfactory_handle); reinterpret_cast(jopt_handle) ->compaction_filter_factory = *cff_factory; diff --git a/java/rocksjni/transaction.cc b/java/rocksjni/transaction.cc index 42c1b47d2..2c09155a4 100644 --- a/java/rocksjni/transaction.cc +++ b/java/rocksjni/transaction.cc @@ -48,7 +48,7 @@ void Java_org_rocksdb_Transaction_setSnapshotOnNextOperation__JJ( jlong jtxn_notifier_handle) { auto* txn = reinterpret_cast(jhandle); auto* txn_notifier = - reinterpret_cast*>( + reinterpret_cast*>( jtxn_notifier_handle); txn->SetSnapshotOnNextOperation(*txn_notifier); }