From e8710303d9fbe5e659afece7717a46c1bb9926fd Mon Sep 17 00:00:00 2001 From: Peter Dillinger Date: Wed, 24 May 2023 16:49:17 -0700 Subject: [PATCH] Document SyncPoint::LoadDependency (#11477) Summary: It's easy to mix up the ordering when it's undocumented. For an example of the meaning of the order, see DBTest.ThreadStatusFlush. Pull Request resolved: https://github.com/facebook/rocksdb/pull/11477 Test Plan: comments only Reviewed By: jaykorean Differential Revision: D46166683 Pulled By: pdillinger fbshipit-source-id: 33118ba7ef1b08eab7b077548fe2e70f2c309e3f --- test_util/sync_point.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test_util/sync_point.h b/test_util/sync_point.h index 65f1239ec..6022073e5 100644 --- a/test_util/sync_point.h +++ b/test_util/sync_point.h @@ -85,7 +85,9 @@ class SyncPoint { }; // call once at the beginning of a test to setup the dependency between - // sync points + // sync points. Specifically, execution will not be allowed to proceed past + // each successor until execution has reached the corresponding predecessor, + // in any thread. void LoadDependency(const std::vector& dependencies); // call once at the beginning of a test to setup the dependency between