From eb53c05a359edf95716a8c65a828f2215bbc940f Mon Sep 17 00:00:00 2001 From: Zun Wang Date: Wed, 6 Jul 2016 12:54:01 -0700 Subject: [PATCH] Add comment for GetBackupInfo about returned BackupInfos order Summary: #title Test Plan: n/a Reviewers: uddipta, ldemailly, andrewkr Reviewed By: andrewkr Subscribers: andrewkr, dhruba Differential Revision: https://reviews.facebook.net/D60393 --- utilities/backupable/backupable_db.cc | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/utilities/backupable/backupable_db.cc b/utilities/backupable/backupable_db.cc index 0dc7092b3..fb2a68b31 100644 --- a/utilities/backupable/backupable_db.cc +++ b/utilities/backupable/backupable_db.cc @@ -99,6 +99,8 @@ class BackupEngineImpl : public BackupEngine { } Status GarbageCollect() override; + // The returned BackupInfos are in chronological order, which means the + // latest backup comes last. void GetBackupInfo(std::vector* backup_info) override; void GetCorruptedBackups(std::vector* corrupt_backup_ids) override; Status RestoreDBFromBackup( @@ -1769,6 +1771,8 @@ class BackupEngineReadOnlyImpl : public BackupEngineReadOnly { virtual ~BackupEngineReadOnlyImpl() {} + // The returned BackupInfos are in chronological order, which means the + // latest backup comes last. virtual void GetBackupInfo(std::vector* backup_info) override { backup_engine_->GetBackupInfo(backup_info); }