From f615f5604bd8edfbdda5c3e1e643d2f28934a046 Mon Sep 17 00:00:00 2001 From: gladiator Date: Tue, 12 Sep 2017 17:51:53 -0700 Subject: [PATCH] fix missing manual_wal_flush for DBOptions ctor Summary: currently `ImmutableDBOptions::Dump` use default value for `concurrent_prepare` and `manual_wal_flush`, because DBOptions ctor does not init those member variables. so in LOG file, it will be ``` Options.concurrent_prepare: 0 Options.manual_wal_flush: 0 ``` Closes https://github.com/facebook/rocksdb/pull/2864 Differential Revision: D5816240 Pulled By: ajkr fbshipit-source-id: 82335e8bcae3dceedc6a99224e7998de5fad1e50 --- options/options.cc | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/options/options.cc b/options/options.cc index 7bd2c9582..4d8ba487a 100644 --- a/options/options.cc +++ b/options/options.cc @@ -191,7 +191,9 @@ DBOptions::DBOptions(const Options& options) dump_malloc_stats(options.dump_malloc_stats), avoid_flush_during_recovery(options.avoid_flush_during_recovery), avoid_flush_during_shutdown(options.avoid_flush_during_shutdown), - allow_ingest_behind(options.allow_ingest_behind) { + allow_ingest_behind(options.allow_ingest_behind), + concurrent_prepare(options.concurrent_prepare), + manual_wal_flush(options.manual_wal_flush) { } void DBOptions::Dump(Logger* log) const {