From ffd2a2eefdc6ad4223dff57a4ae1735b701c198a Mon Sep 17 00:00:00 2001 From: Andrew Kryczka Date: Wed, 19 Jul 2017 20:26:46 -0700 Subject: [PATCH] delete ExpandInputsToCleanCut failure log Summary: I decided not even to keep it as an INFO-level log as it is too normal for compactions to be skipped due to locked input files. Removing logging here makes us consistent with how we treat locked files that weren't pulled in due to overlap. We may want some error handling on line 422, which should never happen when called by `LevelCompactionBuilder::PickCompaction`, as `SetupInitialFiles` skips compactions where overlap causes the output level to pull in locked files. Closes https://github.com/facebook/rocksdb/pull/2617 Differential Revision: D5458502 Pulled By: ajkr fbshipit-source-id: c2e5f867c0a77c1812ce4242ab3e085b3eee0bae --- db/compaction_picker.cc | 5 ----- 1 file changed, 5 deletions(-) diff --git a/db/compaction_picker.cc b/db/compaction_picker.cc index 6795227b5..f06351c70 100644 --- a/db/compaction_picker.cc +++ b/db/compaction_picker.cc @@ -234,11 +234,6 @@ bool CompactionPicker::ExpandInputsToCleanCut(const std::string& cf_name, // If, after the expansion, there are files that are already under // compaction, then we must drop/cancel this compaction. if (AreFilesInCompaction(inputs->files)) { - ROCKS_LOG_WARN( - ioptions_.info_log, - "[%s] ExpandWhileOverlapping() failure because some of the necessary" - " compaction input files are currently being compacted.", - cf_name.c_str()); return false; } return true;