72502cf227
Revert "comment out unused parameters"
...
Summary:
This reverts the previous commit 1d7048c598https://github.com/facebook/rocksdb/pull/2627
Differential Revision: D5476473
Pulled By: sagar0
fbshipit-source-id: 4756ff5c0dfc88c17eceb00e02c36176de728d06
7 years ago
1d7048c598
comment out unused parameters
...
Summary: This uses `clang-tidy` to comment out unused parameters (in functions, methods and lambdas) in fbcode. Cases that the tool failed to handle are fixed manually.
Reviewed By: igorsugak
Differential Revision: D5454343
fbshipit-source-id: 5dee339b4334e25e963891b519a5aa81fbf627b2
7 years ago
3c327ac2d0
Change RocksDB License
...
Summary: Closes https://github.com/facebook/rocksdb/pull/2589
Differential Revision: D5431502
Pulled By: siying
fbshipit-source-id: 8ebf8c87883daa9daa54b2303d11ce01ab1f6f75
7 years ago
d616ebea23
Add GPLv2 as an alternative license.
...
Summary: Closes https://github.com/facebook/rocksdb/pull/2226
Differential Revision: D4967547
Pulled By: siying
fbshipit-source-id: dd3b58ae1e7a106ab6bb6f37ab5c88575b125ab4
8 years ago
2914de64e8
add sim_cache stats to Statistics
...
Summary:
add SIM_BLOCK_CACHE_HIT and SIM_BLOCK_CACHE_MISS tickers.
maybe can be combined with Histograms like DB_GET to evaluate the current setting of the size of block cache.
Test Plan: make all check
Reviewers: sdong, andrewkr, IslamAbdelRahman, yiwu
Reviewed By: yiwu
Subscribers: andrewkr, dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D61803
8 years ago
630b732cb3
fix flaky sim_cache_test
...
Summary: fix flaky test
Test Plan: `make all check`
Reviewers: sdong, andrewkr
Reviewed By: andrewkr
Subscribers: andrewkr, dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D59157
8 years ago
5d660258e7
add simulator Cache as class SimCache/SimLRUCache(with test)
...
Summary: add class SimCache(base class with instrumentation api) and SimLRUCache(derived class with detailed implementation) which is used as an instrumented block cache that can predict hit rate for different cache size
Test Plan:
Add a test case in `db_block_cache_test.cc` called `SimCacheTest` to test basic logic of SimCache.
Also add option `-simcache_size` in db_bench. if set with a value other than -1, then the benchmark will use this value as the size of the simulator cache and finally output the simulation result.
```
[gzh@dev9927.prn1 ~/local/rocksdb] ./db_bench -benchmarks "fillseq,readrandom" -cache_size 1000000 -simcache_size 1000000
RocksDB: version 4.8
Date: Tue May 17 16:56:16 2016
CPU: 32 * Intel(R) Xeon(R) CPU E5-2660 0 @ 2.20GHz
CPUCache: 20480 KB
Keys: 16 bytes each
Values: 100 bytes each (50 bytes after compression)
Entries: 1000000
Prefix: 0 bytes
Keys per prefix: 0
RawSize: 110.6 MB (estimated)
FileSize: 62.9 MB (estimated)
Write rate: 0 bytes/second
Compression: Snappy
Memtablerep: skip_list
Perf Level: 0
WARNING: Assertions are enabled; benchmarks unnecessarily slow
------------------------------------------------
DB path: [/tmp/rocksdbtest-112628/dbbench]
fillseq : 6.809 micros/op 146874 ops/sec; 16.2 MB/s
DB path: [/tmp/rocksdbtest-112628/dbbench]
readrandom : 6.343 micros/op 157665 ops/sec; 17.4 MB/s (1000000 of 1000000 found)
SIMULATOR CACHE STATISTICS:
SimCache LOOKUPs: 986559
SimCache HITs: 264760
SimCache HITRATE: 26.84%
[gzh@dev9927.prn1 ~/local/rocksdb] ./db_bench -benchmarks "fillseq,readrandom" -cache_size 1000000 -simcache_size 10000000
RocksDB: version 4.8
Date: Tue May 17 16:57:10 2016
CPU: 32 * Intel(R) Xeon(R) CPU E5-2660 0 @ 2.20GHz
CPUCache: 20480 KB
Keys: 16 bytes each
Values: 100 bytes each (50 bytes after compression)
Entries: 1000000
Prefix: 0 bytes
Keys per prefix: 0
RawSize: 110.6 MB (estimated)
FileSize: 62.9 MB (estimated)
Write rate: 0 bytes/second
Compression: Snappy
Memtablerep: skip_list
Perf Level: 0
WARNING: Assertions are enabled; benchmarks unnecessarily slow
------------------------------------------------
DB path: [/tmp/rocksdbtest-112628/dbbench]
fillseq : 5.066 micros/op 197394 ops/sec; 21.8 MB/s
DB path: [/tmp/rocksdbtest-112628/dbbench]
readrandom : 6.457 micros/op 154870 ops/sec; 17.1 MB/s (1000000 of 1000000 found)
SIMULATOR CACHE STATISTICS:
SimCache LOOKUPs: 1059764
SimCache HITs: 374501
SimCache HITRATE: 35.34%
[gzh@dev9927.prn1 ~/local/rocksdb] ./db_bench -benchmarks "fillseq,readrandom" -cache_size 1000000 -simcache_size 100000000
RocksDB: version 4.8
Date: Tue May 17 16:57:32 2016
CPU: 32 * Intel(R) Xeon(R) CPU E5-2660 0 @ 2.20GHz
CPUCache: 20480 KB
Keys: 16 bytes each
Values: 100 bytes each (50 bytes after compression)
Entries: 1000000
Prefix: 0 bytes
Keys per prefix: 0
RawSize: 110.6 MB (estimated)
FileSize: 62.9 MB (estimated)
Write rate: 0 bytes/second
Compression: Snappy
Memtablerep: skip_list
Perf Level: 0
WARNING: Assertions are enabled; benchmarks unnecessarily slow
------------------------------------------------
DB path: [/tmp/rocksdbtest-112628/dbbench]
fillseq : 5.632 micros/op 177572 ops/sec; 19.6 MB/s
DB path: [/tmp/rocksdbtest-112628/dbbench]
readrandom : 6.892 micros/op 145094 ops/sec; 16.1 MB/s (1000000 of 1000000 found)
SIMULATOR CACHE STATISTICS:
SimCache LOOKUPs: 1150767
SimCache HITs: 1034535
SimCache HITRATE: 89.90%
```
Reviewers: IslamAbdelRahman, andrewkr, sdong
Reviewed By: sdong
Subscribers: MarkCallaghan, andrewkr, dhruba, leveldb
Differential Revision: https://reviews.facebook.net/D57999
8 years ago
Sagar Vemuri