rocksdb

Commit Graph

Author	SHA1	Message	Date
Maggie Moss	659d0e602e	Run Define codemod in fbcode Summary: Found a callsite for `moo_translate` in the Scuba warnings and realized we have a few calls to `define()` left in fbcode. - I ran the `DefineCodemod` script against fbcode - Fixed broken tests, and ensured that tests that are explicitly testing the behaviour of `define()` were not changed. bypass-lint Reviewed By: kmeht Differential Revision: D12968447 fbshipit-source-id: d8fd3649a2ce9868b8938d293e1bebf1a6d2fad8	7 years ago
Neal Poole	dfa6c23c4b	Update RocksDBCommonHelper to use escapeshellarg Summary: Most of the data used here in shell commands is not generated directly from user input but some data (ie: from environment variables) may have been external influenced. It is a good practice to escape this data before using it in a shell command. Originally D4800264 but we never quite got it merged. Reviewed By: yiwu-arbug Differential Revision: D5595052 fbshipit-source-id: c09d8b47fe35fc6a47afb4933ccad9d56ca8d7be	8 years ago
Andres Suarez	3ce20e985b	Fix use of RocksDBCommonHelper in cont_integration.sh Reviewed By: mzlee Differential Revision: D5472936 fbshipit-source-id: cf75858f879f1192b468a9020005634a5afad880	8 years ago

Author

SHA1

Message

Date

Maggie Moss

659d0e602e

Run Define codemod in fbcode

Summary:
Found a callsite for `moo_translate` in the Scuba warnings and realized we have a few calls to `define()` left in fbcode.

- I ran the `DefineCodemod` script against fbcode
- Fixed broken tests, and ensured that tests that are explicitly testing the behaviour of `define()` were not changed.

bypass-lint

Reviewed By: kmeht

Differential Revision: D12968447

fbshipit-source-id: d8fd3649a2ce9868b8938d293e1bebf1a6d2fad8

7 years ago

Neal Poole

dfa6c23c4b

Update RocksDBCommonHelper to use escapeshellarg

Summary:
Most of the data used here in shell commands is not generated directly from user input but some data (ie: from environment variables) may have been external influenced. It is a good practice to escape this data before using it in a shell command.

Originally D4800264 but we never quite got it merged.

Reviewed By: yiwu-arbug

Differential Revision: D5595052

fbshipit-source-id: c09d8b47fe35fc6a47afb4933ccad9d56ca8d7be

8 years ago

Andres Suarez

3ce20e985b

Fix use of RocksDBCommonHelper in cont_integration.sh

Reviewed By: mzlee

Differential Revision: D5472936

fbshipit-source-id: cf75858f879f1192b468a9020005634a5afad880

8 years ago

3 Commits (85394a96ca9e3361bc1be0fc4df5d8a2b4f3ab25)