rocksdb

fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

History

Yanqin Jin 2b367fa8cc Fix bug caused by releasing snapshot(s) during compaction (#8608 ) Summary: In debug mode, we are seeing assertion failure as follows ``` db/compaction/compaction_iterator.cc:980: void rocksdb::CompactionIterator::PrepareOutput(): \ Assertion `ikey_.type != kTypeDeletion && ikey_.type != kTypeSingleDeletion' failed. ``` It is caused by releasing earliest snapshot during compaction between the execution of `NextFromInput()` and `PrepareOutput()`. In one case, as demonstrated in unit test `WritePreparedTransaction.ReleaseEarliestSnapshotDuringCompaction_WithSD2`, incorrect result may be returned by a following range scan if we disable assertion, as in opt compilation level: the SingleDelete marker's sequence number is zeroed out, but the preceding PUT is also outputted to the SST file after compaction. Due to the logic of DBIter, the PUT will not be skipped and will be returned by iterator in range scan. https://github.com/facebook/rocksdb/issues/8661 illustrates what happened. Fix by taking a more conservative approach: make compaction zero out sequence number only if key is in the earliest snapshot when the compaction starts. Another assertion failure is ``` Assertion `current_user_key_snapshot_ == last_snapshot' failed. ``` It's caused by releasing the snapshot between the PUT and SingleDelete during compaction. Pull Request resolved: https://github.com/facebook/rocksdb/pull/8608 Test Plan: make check Reviewed By: jay-zhuang Differential Revision: D30145645 Pulled By: riversand963 fbshipit-source-id: 699f58e66faf70732ad53810ccef43935d3bbe81		3 years ago
..
clipping_iterator.h	Add a clipping internal iterator (#8327 )	3 years ago
clipping_iterator_test.cc	Add a clipping internal iterator (#8327 )	3 years ago
compaction.cc	Move old files to warm tier in FIFO compactions (#8310 )	3 years ago
compaction.h	Move old files to warm tier in FIFO compactions (#8310 )	3 years ago
compaction_iteration_stats.h	Add statistics support to integrated BlobDB (#8667 )	3 years ago
compaction_iterator.cc	Fix bug caused by releasing snapshot(s) during compaction (#8608 )	3 years ago
compaction_iterator.h	Fix bug caused by releasing snapshot(s) during compaction (#8608 )	3 years ago
compaction_iterator_test.cc	Fix bug caused by releasing snapshot(s) during compaction (#8608 )	3 years ago
compaction_job.cc	Add statistics support to integrated BlobDB (#8667 )	3 years ago
compaction_job.h	Add sub-compaction support for RemoteCompaction (#8364 )	3 years ago
compaction_job_stats_test.cc	Add more tests to ASSERT_STATUS_CHECKED (3), API change (#7715 )	4 years ago
compaction_job_test.cc	Move old files to warm tier in FIFO compactions (#8310 )	3 years ago
compaction_picker.cc	Move old files to warm tier in FIFO compactions (#8310 )	3 years ago
compaction_picker.h	Make ImmutableOptions struct that inherits from ImmutableCFOptions and ImmutableDBOptions (#8262 )	4 years ago
compaction_picker_fifo.cc	Move old files to warm tier in FIFO compactions (#8310 )	3 years ago
compaction_picker_fifo.h	Move old files to warm tier in FIFO compactions (#8310 )	3 years ago
compaction_picker_level.cc	Move old files to warm tier in FIFO compactions (#8310 )	3 years ago
compaction_picker_level.h	Make ImmutableOptions struct that inherits from ImmutableCFOptions and ImmutableDBOptions (#8262 )	4 years ago
compaction_picker_test.cc	Move old files to warm tier in FIFO compactions (#8310 )	3 years ago
compaction_picker_universal.cc	Move old files to warm tier in FIFO compactions (#8310 )	3 years ago
compaction_picker_universal.h	Make ImmutableOptions struct that inherits from ImmutableCFOptions and ImmutableDBOptions (#8262 )	4 years ago
compaction_service_test.cc	Make MergeOperator+CompactionFilter/Factory into Customizable Classes (#8481 )	3 years ago
sst_partitioner.cc	SST Partitioner interface that allows to split SST files (#6957 )	4 years ago