fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Hui Xiao 1ababeb76a Deallocate payload of BlockBasedTableBuilder::Rep::FilterBlockBuilder earlier for Full/PartitionedFilter (#9070) ... Summary: Note: This PR is the 1st part of a bigger PR stack (https://github.com/facebook/rocksdb/pull/9073). Context: Previously, the payload (i.e, filter data) within `BlockBasedTableBuilder::Rep::FilterBlockBuilder` object is not deallocated until `BlockBasedTableBuilder` is deallocated, despite it is no longer useful after its related `filter_content` being written. - Transferred the payload (i.e, the filter data) out of `BlockBasedTableBuilder::Rep::FilterBlockBuilder` object - For PartitionedFilter: - Unified `filters` and `filter_gc` lists into one `std::deque<FilterEntry> filters` by adding a new field `last_filter_entry_key` and storing the `std::unique_ptr filter_data` with the `Slice filter` in the same entry - Reset `last_filter_data` in the case where `filters` is empty, which should be as by then we would've finish using all the `Slice filter` - Deallocated the payload by going out of scope as soon as we're done with using the `filter_content` associated with the payload - This is an internal interface change at the level of `FilterBlockBuilder::Finish()`, which leads to touching the inherited interface in `BlockBasedFilterBlockBuilder`. But for that, the payload transferring is ignored. Pull Request resolved: https://github.com/facebook/rocksdb/pull/9070 Test Plan: - The main focus is to catch segment fault error during `FilterBlockBuilder::Finish()` and `BlockBasedTableBuilder::Finish()` and interface mismatch. Relying on existing CI tests is enough as `assert(false)` was temporarily added to verify the new logic of transferring ownership indeed run Reviewed By: pdillinger Differential Revision: D31884933 Pulled By: hx235 fbshipit-source-id: f73ecfbea13788d4fc058013ace27230110b52f4		3 years ago
..
adaptive	Refactor: use TableBuilderOptions to reduce parameter lists (#8240)	4 years ago
block_based	Deallocate payload of BlockBasedTableBuilder::Rep::FilterBlockBuilder earlier for Full/PartitionedFilter (#9070)	3 years ago
cuckoo	Cleanup includes in dbformat.h (#8930)	3 years ago
plain	Cleanup includes in dbformat.h (#8930)	3 years ago
block_fetcher.cc	Rename variables in ImmutableCFOptions to avoid conflicts with ImmutableDBOptions (#8227)	4 years ago
block_fetcher.h	Add db_test2 to to ASSERT_STATUS_CHECKED (#8640)	3 years ago
block_fetcher_test.cc	Cleanup includes in dbformat.h (#8930)	3 years ago
cleanable_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
format.cc	Some checksum code refactoring (#9113)	3 years ago
format.h	Some checksum code refactoring (#9113)	3 years ago
get_context.cc	Cleanup includes in dbformat.h (#8930)	3 years ago
get_context.h	Cleanup includes in dbformat.h (#8930)	3 years ago
internal_iterator.h	Clean up InternalIterator upper bound logic a little bit (#7200)	4 years ago
iter_heap.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
iterator.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
iterator_wrapper.h	Redesign block cache pinning API (#7520)	4 years ago
merger_test.cc	Cleanup multiple implementations of VectorIterator (#8901)	3 years ago
merging_iterator.cc	MergingIterator: rearrange fields to reduce paddings (#9024)	3 years ago
merging_iterator.h	Cleanup includes in dbformat.h (#8930)	3 years ago
meta_blocks.cc	Cleanup includes in dbformat.h (#8930)	3 years ago
meta_blocks.h	Make ImmutableOptions struct that inherits from ImmutableCFOptions and ImmutableDBOptions (#8262)	4 years ago
mock_table.cc	Introduce a mechanism to dump out blocks from block cache and re-insert to secondary cache (#8912)	3 years ago
mock_table.h	Fix some minor issues in the Customizable infrastructure (#8566)	3 years ago
multiget_context.h	Batch blob read IO for MultiGet (#8699)	3 years ago
persistent_cache_helper.cc	Add more tests to ASSERT_STATUS_CHECKED (#7367)	4 years ago
persistent_cache_helper.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
persistent_cache_options.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
scoped_arena_iterator.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
sst_file_dumper.cc	Make it possible to apply only a subrange of table property collectors (#8298)	4 years ago
sst_file_dumper.h	Make ImmutableOptions struct that inherits from ImmutableCFOptions and ImmutableDBOptions (#8262)	4 years ago
sst_file_reader.cc	Make ImmutableOptions struct that inherits from ImmutableCFOptions and ImmutableDBOptions (#8262)	4 years ago
sst_file_reader_test.cc	Support timestamps in SstFileWriter (#8899)	3 years ago
sst_file_writer.cc	Support timestamps in SstFileWriter (#8899)	3 years ago
sst_file_writer_collectors.h	Cleanup includes in dbformat.h (#8930)	3 years ago
table_builder.h	Partially revert the "apply subrange of table property collectors" change (#8465)	4 years ago
table_factory.cc	Add customizable_util.h to the public API (#8301)	4 years ago
table_properties.cc	Experimental support for SST unique IDs (#8990)	3 years ago
table_properties_internal.h	Experimental support for SST unique IDs (#8990)	3 years ago
table_reader.h	dedup ReadOptions in iterator hierarchy (#7210)	4 years ago
table_reader_bench.cc	Make it possible to apply only a subrange of table property collectors (#8298)	4 years ago
table_reader_caller.h	Fix and detect headers with missing dependencies (#8893)	3 years ago
table_test.cc	Some checksum code refactoring (#9113)	3 years ago
two_level_iterator.cc	Clarify caching behavior for index and filter partitions (#9068)	3 years ago
two_level_iterator.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
unique_id.cc	Experimental support for SST unique IDs (#8990)	3 years ago
unique_id_impl.h	Experimental support for SST unique IDs (#8990)	3 years ago