You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Peter Dillinger
1e403a0c6c
Fix assertion failure in FastLocalBloomBitsBuilder ( #9585 )
...
Summary:
As in
```
db_stress: table/block_based/filter_policy.cc:316: rocksdb::{anonymous}::FastLocalBloomBitsBuilder::FastLocalBloomBitsBuilder(int, std::atomic<long int>*, std::shared_ptr<rocksdb::CacheReservationManager>, bool): Assertion `millibits_per_key >= 1000' failed.
```
This assertion failure was actually happening with our RibbonFilterPolicy
which falls back to Bloom for some cases, often for flush, but was
missing new special logic to skip generating filter for 0 bits per key
case. Fixed by adding the logic in other builtin FilterPolicy
implementations.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/9585
Test Plan:
Updated db_bloom_filter_test to do more integration testing
of the RibbonFilterPolicy ("auto Ribbon") class, incl regression test
this with SkipFilterOnEssentiallyZeroBpk
Reviewed By: ajkr
Differential Revision: D34295101
Pulled By: pdillinger
fbshipit-source-id: 3488eb207fc1d67bbbd1301313714aa1b6406e6e
3 years ago
..
adaptive
More refactoring ahead of footer & meta changes ( #9240 )
3 years ago
block_based
Fix assertion failure in FastLocalBloomBitsBuilder ( #9585 )
3 years ago
cuckoo
Optimize & clean up footer code ( #9280 )
3 years ago
plain
Fast path for detecting unchanged prefix_extractor ( #9407 )
3 years ago
block_fetcher.cc
More refactoring ahead of footer & meta changes ( #9240 )
3 years ago
block_fetcher.h
More refactoring ahead of footer & meta changes ( #9240 )
3 years ago
block_fetcher_test.cc
Make MemoryAllocator into a Customizable class ( #8980 )
3 years ago
cleanable_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
format.cc
Optimize & clean up footer code ( #9280 )
3 years ago
format.h
Optimize & clean up footer code ( #9280 )
3 years ago
get_context.cc
Support readahead during compaction for blob files ( #9187 )
3 years ago
get_context.h
Cleanup includes in dbformat.h ( #8930 )
3 years ago
internal_iterator.h
Reuse internal auto readhead_size at each Level (expect L0) for Iterations ( #9056 )
3 years ago
iter_heap.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
iterator.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
iterator_wrapper.h
Reuse internal auto readhead_size at each Level (expect L0) for Iterations ( #9056 )
3 years ago
merger_test.cc
Cleanup multiple implementations of VectorIterator ( #8901 )
3 years ago
merging_iterator.cc
MergingIterator: rearrange fields to reduce paddings ( #9024 )
3 years ago
merging_iterator.h
Cleanup includes in dbformat.h ( #8930 )
3 years ago
meta_blocks.cc
Add NewMetaDataIterator method ( #8692 )
3 years ago
meta_blocks.h
More refactoring ahead of footer & meta changes ( #9240 )
3 years ago
mock_table.cc
Introduce a mechanism to dump out blocks from block cache and re-insert to secondary cache ( #8912 )
3 years ago
mock_table.h
Fix some minor issues in the Customizable infrastructure ( #8566 )
4 years ago
multiget_context.h
Fix major bug with MultiGet, DeleteRange, and memtable Bloom ( #9453 )
3 years ago
persistent_cache_helper.cc
New stable, fixed-length cache keys ( #9126 )
3 years ago
persistent_cache_helper.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
persistent_cache_options.h
New stable, fixed-length cache keys ( #9126 )
3 years ago
scoped_arena_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
sst_file_dumper.cc
Use the comparator from the sst file table properties in sst_dump_tool ( #9491 )
3 years ago
sst_file_dumper.h
Make ImmutableOptions struct that inherits from ImmutableCFOptions and ImmutableDBOptions ( #8262 )
4 years ago
sst_file_reader.cc
Fast path for detecting unchanged prefix_extractor ( #9407 )
3 years ago
sst_file_reader_test.cc
Use the comparator from the sst file table properties in sst_dump_tool ( #9491 )
3 years ago
sst_file_writer.cc
Support timestamps in SstFileWriter ( #8899 )
3 years ago
sst_file_writer_collectors.h
Cleanup includes in dbformat.h ( #8930 )
3 years ago
table_builder.h
Fast path for detecting unchanged prefix_extractor ( #9407 )
3 years ago
table_factory.cc
Restore Regex support for ObjectLibrary::Register, rename new APIs to allow old one to be deprecated in the future ( #9362 )
3 years ago
table_properties.cc
Improve / clean up meta block code & integrity ( #9163 )
3 years ago
table_properties_internal.h
Improve / clean up meta block code & integrity ( #9163 )
3 years ago
table_reader.h
dedup ReadOptions in iterator hierarchy ( #7210 )
5 years ago
table_reader_bench.cc
Fast path for detecting unchanged prefix_extractor ( #9407 )
3 years ago
table_reader_caller.h
Fix and detect headers with missing dependencies ( #8893 )
3 years ago
table_test.cc
Hide deprecated, inefficient block-based filter from public API ( #9535 )
3 years ago
two_level_iterator.cc
Clarify caching behavior for index and filter partitions ( #9068 )
3 years ago
two_level_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
unique_id.cc
Experimental support for SST unique IDs ( #8990 )
3 years ago
unique_id_impl.h
Experimental support for SST unique IDs ( #8990 )
3 years ago