You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Peter Dillinger
c5afbbfe4b
Don't wait for indirect flush in read-only DB ( #10569 )
...
Summary:
Some APIs for getting live files, which are used by Checkpoint
and BackupEngine, can optionally trigger and wait for a flush. These
would deadlock when used on a read-only DB. Here we fix that by assuming
the user wants the overall operation to succeed and is OK without
flushing (because the DB is read-only).
Follow-up work: the same or other issues can be hit by directly invoking
some DB functions that are clearly not appropriate for read-only
instance, but are not covered by overrides in DBImplReadOnly and
CompactedDBImpl. These should be fixed to avoid similar problems on
accidental misuse. (Long term, it would be nice to have a DBReadOnly
class without those members, like BackupEngineReadOnly.)
Pull Request resolved: https://github.com/facebook/rocksdb/pull/10569
Test Plan: tests updated to catch regression (hang before the fix)
Reviewed By: riversand963
Differential Revision: D38995759
Pulled By: pdillinger
fbshipit-source-id: f5f8bc7123e13cb45bd393dd974d7d6eda20bc68
2 years ago
..
agg_merge
Add Aggregation Merge Operator ( #9780 )
3 years ago
backup
Don't wait for indirect flush in read-only DB ( #10569 )
2 years ago
blob_db
Remove own ToString() ( #9955 )
3 years ago
cassandra
Migrate to docker for CI run ( #10496 )
2 years ago
checkpoint
Fix race condition with WAL tracking and `FlushWAL(true /* sync */)` ( #10185 )
2 years ago
compaction_filters
Make MergeOperator+CompactionFilter/Factory into Customizable Classes ( #8481 )
3 years ago
convenience
Add a SystemClock class to capture the time functions of an Env ( #7858 )
4 years ago
leveldb_options
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
memory
Remove own ToString() ( #9955 )
3 years ago
merge_operators
Remove using namespace ( #9369 )
3 years ago
option_change_migration
Fix some typos in comments and HISTORY.md ( #9798 )
3 years ago
options
Remove own ToString() ( #9955 )
3 years ago
persistent_cache
Remove code that only compiles for Visual Studio versions older than 2015 ( #10065 )
3 years ago
simulator_cache
Have Cache use Status::MemoryLimit ( #10262 )
2 years ago
table_properties_collectors
Remove own ToString() ( #9955 )
3 years ago
trace
Add rate limiter priority to ReadOptions ( #9424 )
3 years ago
transactions
Fix two extra headers ( #10525 )
2 years ago
ttl
Migrate to docker for CI run ( #10496 )
2 years ago
write_batch_with_index
Migrate to docker for CI run ( #10496 )
2 years ago
cache_dump_load.cc
Introduce a mechanism to dump out blocks from block cache and re-insert to secondary cache ( #8912 )
3 years ago
cache_dump_load_impl.cc
Derive cache keys from SST unique IDs ( #10394 )
2 years ago
cache_dump_load_impl.h
Remove deprecated block-based filter ( #10184 )
2 years ago
compaction_filters.cc
Restore Regex support for ObjectLibrary::Register, rename new APIs to allow old one to be deprecated in the future ( #9362 )
3 years ago
counted_fs.cc
Fix serious FSDirectory use-after-Close bug (missing fsync) ( #10460 )
2 years ago
counted_fs.h
Explicitly closing all directory file descriptors ( #10049 )
2 years ago
debug.cc
Add helper function to get debug type name ( #10243 )
2 years ago
env_mirror.cc
Fix clang13 build error ( #9374 )
3 years ago
env_mirror_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
env_timed.cc
Make FileSystem a Customizable Class ( #8649 )
3 years ago
env_timed.h
Make FileSystem a Customizable Class ( #8649 )
3 years ago
env_timed_test.cc
Make env*_test work with ASSERT_STATUS_CHECKED ( #7176 )
4 years ago
fault_injection_env.cc
Explicitly closing all directory file descriptors ( #10049 )
2 years ago
fault_injection_env.h
Explicitly closing all directory file descriptors ( #10049 )
2 years ago
fault_injection_fs.cc
Add missing synchronization in TestFSWritableFile ( #10544 )
2 years ago
fault_injection_fs.h
Add missing synchronization in TestFSWritableFile ( #10544 )
2 years ago
fault_injection_secondary_cache.cc
Fix the memory leak in db_stress tests that are caused by `FaultInjectionSecondaryCache` and add `CompressedSecondaryCache` into stress tests. ( #10523 )
2 years ago
fault_injection_secondary_cache.h
Fix the memory leak in db_stress tests that are caused by `FaultInjectionSecondaryCache` and add `CompressedSecondaryCache` into stress tests. ( #10523 )
2 years ago
memory_allocators.h
Make MemoryAllocator into a Customizable class ( #8980 )
3 years ago
merge_operators.cc
Restore Regex support for ObjectLibrary::Register, rename new APIs to allow old one to be deprecated in the future ( #9362 )
3 years ago
merge_operators.h
Make MergeOperator+CompactionFilter/Factory into Customizable Classes ( #8481 )
3 years ago
object_registry.cc
Added GetFactoryCount/Names/Types to ObjectRegistry ( #9358 )
3 years ago
object_registry_test.cc
Added GetFactoryCount/Names/Types to ObjectRegistry ( #9358 )
3 years ago
util_merge_operators_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
wal_filter.cc
Make WalFilter, SstPartitionerFactory, FileChecksumGenFactory, and TableProperties Customizable ( #8638 )
3 years ago