You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Ramkumar Vadivelu
9a690a74e1
In ParseInternalKey(), include corrupt key info in Status ( #7515 )
...
Summary:
Fixes Issue https://github.com/facebook/rocksdb/issues/7497
When allow_data_in_errors db_options is set, log error key details in `ParseInternalKey()`
Have fixed most of the calls. Have few TODOs still pending - because have to make more deeper changes to pass in the allow_data_in_errors flag. Will do those in a separate PR later.
Tests:
- make check
- some of the existing tests that exercise the "internal key too small" condition are: dbformat_test, cuckoo_table_builder_test
- some of the existing tests that exercise the corrupted key path are: corruption_test, merge_helper_test, compaction_iterator_test
Example of new status returns:
- Key too small - `Corrupted Key: Internal Key too small. Size=5`
- Corrupt key with allow_data_in_errors option set to false: `Corrupted Key: '<redacted>' seq:3, type:3`
- Corrupt key with allow_data_in_errors option set to true: `Corrupted Key: '61' seq:3, type:3`
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7515
Reviewed By: ajkr
Differential Revision: D24240264
Pulled By: ramvadiv
fbshipit-source-id: bc48f5d4475ac19d7713e16df37505b31aac42e7
4 years ago
..
adaptive
Bring the Configurable options together ( #5753 )
4 years ago
block_based
In ParseInternalKey(), include corrupt key info in Status ( #7515 )
4 years ago
cuckoo
In ParseInternalKey(), include corrupt key info in Status ( #7515 )
4 years ago
plain
In ParseInternalKey(), include corrupt key info in Status ( #7515 )
4 years ago
block_fetcher.cc
Skip unnecessary allocation for mmap reads under 5000 bytes ( #7043 )
5 years ago
block_fetcher.h
Reduce memory copies when fetching and uncompressing blocks from SST files ( #6689 )
5 years ago
block_fetcher_test.cc
Add Status check enforcement for unit tests ( #7464 )
4 years ago
cleanable_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
format.cc
Add a host location property to TableProperties ( #7479 )
4 years ago
format.h
Add a host location property to TableProperties ( #7479 )
4 years ago
get_context.cc
Introduce BlobFileCache and add support for blob files to Get() ( #7540 )
4 years ago
get_context.h
Introduce BlobFileCache and add support for blob files to Get() ( #7540 )
4 years ago
internal_iterator.h
Clean up InternalIterator upper bound logic a little bit ( #7200 )
4 years ago
iter_heap.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
iterator.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
iterator_wrapper.h
Redesign block cache pinning API ( #7520 )
4 years ago
merger_test.cc
More Makefile Cleanup ( #7097 )
5 years ago
merging_iterator.cc
Add some simulator cache and block tracer tests to ASSERT_STATUS_CHECKED ( #7305 )
4 years ago
merging_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
meta_blocks.cc
Add a host location property to TableProperties ( #7479 )
4 years ago
meta_blocks.h
Extend Get/MultiGet deadline support to table open ( #6982 )
5 years ago
mock_table.cc
In ParseInternalKey(), include corrupt key info in Status ( #7515 )
4 years ago
mock_table.h
Introduce options.check_flush_compaction_key_order ( #7467 )
4 years ago
multiget_context.h
Status check enforcement for timestamp_basic_test ( #7454 )
4 years ago
persistent_cache_helper.cc
Add more tests to ASSERT_STATUS_CHECKED ( #7367 )
4 years ago
persistent_cache_helper.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
persistent_cache_options.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
scoped_arena_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
sst_file_dumper.cc
In ParseInternalKey(), include corrupt key info in Status ( #7515 )
4 years ago
sst_file_dumper.h
Add sst_file_dumper status check ( #7315 )
4 years ago
sst_file_reader.cc
Fix scope of `ReadOptions` in `SstFileReader` ( #7432 )
4 years ago
sst_file_reader_test.cc
Add a host location property to TableProperties ( #7479 )
4 years ago
sst_file_writer.cc
enable Status check assertions for sst_file_reader_test ( #7448 )
4 years ago
sst_file_writer_collectors.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
table_builder.h
Store DB identity and DB session ID in SST files ( #6983 )
5 years ago
table_factory.cc
Add plain_table_db_test to ASSERT_STATUS_CHECKED list ( #7482 )
4 years ago
table_properties.cc
Add a host location property to TableProperties ( #7479 )
4 years ago
table_properties_internal.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
table_reader.h
dedup ReadOptions in iterator hierarchy ( #7210 )
4 years ago
table_reader_bench.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
table_reader_caller.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
table_test.cc
In ParseInternalKey(), include corrupt key info in Status ( #7515 )
4 years ago
two_level_iterator.cc
Redesign block cache pinning API ( #7520 )
4 years ago
two_level_iterator.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago