rocksdb

fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

Hui Xiao 2f76ab150d Fix missing WAL in new manifest by rolling over the WAL deletion record from prev manifest (#10892 ) Summary: Context `Options::track_and_verify_wals_in_manifest = true` verifies each of the WALs tracked in manifest indeed presents in the WAL folder. If not, a corruption "Missing WAL with log number" will be thrown. `DB::SyncWAL()` called at a specific timing (i.e, at the `TEST_SYNC_POINT("FindObsoleteFiles::PostMutexUnlock")`) can record in a new manifest the WAL addition of a WAL file that already had a WAL deletion recorded in the previous manifest. And the WAL deletion record is not rollover-ed to the new manifest. So the new manifest creates the illusion of such WAL never gets deleted and should presents at db re/open. - Such WAL deletion record can be caused by flushing the memtable associated with that WAL and such WAL deletion can actually happen in` PurgeObsoleteFiles()`. As a consequence, upon `DB::Reopen()`, this WAL file can be deleted while manifest still has its WAL addition record , which causes a false alarm of corruption "Missing WAL with log number" to be thrown. Summary This PR fixes this false alarm by rolling over the WAL deletion record from prev manifest to the new manifest by adding the WAL deletion record to the new manifest. Test - Make check - Added new unit test `TEST_F(DBWALTest, FixSyncWalOnObseletedWalWithNewManifestCausingMissingWAL)` that failed before the fix and passed after - [Ongoing]CI stress test + aggressive value as in https://github.com/facebook/rocksdb/pull/10761 , which is how this false alarm was first surfaced, to confirm such false alarm disappears - [Ongoing]Regular CI stress test to confirm such fix didn't harm anything Pull Request resolved: https://github.com/facebook/rocksdb/pull/10892 Reviewed By: ajkr Differential Revision: D40778965 Pulled By: hx235 fbshipit-source-id: a512364bfdeb0b1a55c171890e60d856c528f37f		2 years ago
.circleci	Upgrade CircleCI Windows Build (#10090 )	2 years ago
.github/workflows	ci: add GitHub token permissions for workflow (#10549 )	2 years ago
buckifier	Enable BLACK for internal_repo_rocksdb (#10710 )	2 years ago
build_tools	Print stack traces on frozen tests in CI (#10828 )	2 years ago
cache	Add a SecondaryCache::InsertSaved() API, use in CacheDumper impl (#10945 )	2 years ago
cmake	gcc-11 and cmake related cleanup (#9286 )	3 years ago
coverage	Enable BLACK for internal_repo_rocksdb (#10710 )	2 years ago
db	Fix missing WAL in new manifest by rolling over the WAL deletion record from prev manifest (#10892 )	2 years ago
db_stress_tool	Revert PR 10777 "Fix FIFO causing overlapping seqnos in L0 files due to overla…" (#10999 )	2 years ago
docs	Blog post for Aligning Compaction Output File Boundaries (#10917 )	2 years ago
env	Added placeholders for MADV defines (#10881 )	2 years ago
examples	Add rocksdb_backup_restore_example to examples/.gitignore (#10825 )	2 years ago
file	Fix db_stress failure in async_io in FilePrefetchBuffer (#10949 )	2 years ago
fuzz	Add some missing headers (#10519 )	2 years ago
include/rocksdb	Prevent iterating over range tombstones beyond `iterate_upper_bound` (#10966 )	2 years ago
java	Fix missing WAL in new manifest by rolling over the WAL deletion record from prev manifest (#10892 )	2 years ago
logging	Observe and warn about misconfigured HyperClockCache (#10965 )	2 years ago
memory	Run clang format against files under example/, memory/ and memtable/ folders (#10893 )	2 years ago
memtable	Run clang format against files under example/, memory/ and memtable/ folders (#10893 )	2 years ago
microbench	Avoid allocations/copies for large `GetMergeOperands()` results (#10458 )	2 years ago
monitoring	Add some async read stats (#10947 )	2 years ago
options	Ignore max_compaction_bytes for compaction input that are within output key-range (#10835 )	2 years ago
plugin	Add initial CMake support to plugin (#9214 )	3 years ago
port	Fix include of windows.h in mmap.h (#10885 )	2 years ago
table	Remove copying of range tombstones keys in iterator (#10878 )	2 years ago
test_util	clang format files under test_util/ (#10855 )	2 years ago
third-party	Meta-internal folly integration with F14FastMap (#9546 )	3 years ago
tools	Revert PR 10777 "Fix FIFO causing overlapping seqnos in L0 files due to overla…" (#10999 )	2 years ago
trace_replay	fix compile warnings (#10976 )	2 years ago
util	Fix use of crc32c 3way on portable builds using MSVC (#10667 )	2 years ago
utilities	Add a SecondaryCache::InsertSaved() API, use in CacheDumper impl (#10945 )	2 years ago
.clang-format	A script that automatically reformat affected lines	11 years ago
.gitignore	Git ignore .clangd/ (#10817 )	2 years ago
.lgtm.yml	Create lgtm.yml for LGTM.com C/C++ analysis (#4058 )	7 years ago
.watchmanconfig	Added .watchmanconfig file to rocksdb repo (#5593 )	6 years ago
AUTHORS	Update RocksDB Authors File	7 years ago
CMakeLists.txt	Add a SecondaryCache::InsertSaved() API, use in CacheDumper impl (#10945 )	2 years ago
CODE_OF_CONDUCT.md	Adopt Contributor Covenant	5 years ago
CONTRIBUTING.md	Add Code of Conduct	7 years ago
COPYING	Add GPLv2 as an alternative license.	8 years ago
DEFAULT_OPTIONS_HISTORY.md	Add Options::DisableExtraChecks, clarify force_consistency_checks (#9363 )	3 years ago
DUMP_FORMAT.md	First version of rocksdb_dump and rocksdb_undump.	10 years ago
HISTORY.md	Fix missing WAL in new manifest by rolling over the WAL deletion record from prev manifest (#10892 )	2 years ago
INSTALL.md	Update supported VS versions in INSTALL.md (#9823 )	3 years ago
LANGUAGE-BINDINGS.md	Add grocksdb in Go language bindings (#10498 )	2 years ago
LICENSE.Apache	Change RocksDB License	8 years ago
LICENSE.leveldb	Add back the LevelDB license file	8 years ago
Makefile	Fix broken dependency: update zlib from 1.2.12 to 1.2.13 (#10833 )	2 years ago
PLUGINS.md	Add pmem-rocksdb-plugin link in PLUGINs.md (#9934 )	3 years ago
README.md	Remove Travis CI (#10407 )	2 years ago
ROCKSDB_LITE.md	Fix remaining uses of "backupable" (#9792 )	3 years ago
TARGETS	Add a SecondaryCache::InsertSaved() API, use in CacheDumper impl (#10945 )	2 years ago
USERS.md	Add Apache Spark as a user (#10993 )	2 years ago
Vagrantfile	Adding CentOS 7 Vagrantfile & build script	7 years ago
WINDOWS_PORT.md	Update branch name in WINDOWS_PORT.md (#8745 )	3 years ago
common.mk	Clean up variables for temporary directory (#9961 )	3 years ago
crash_test.mk	Allow a custom DB cleanup command to be passed to db_crashtest.py (#10883 )	2 years ago
issue_template.md	Add Google Group to Issue Template	5 years ago
rocksdb.pc.in	build: fix pkg-config file generation (#9953 )	3 years ago
src.mk	Add a SecondaryCache::InsertSaved() API, use in CacheDumper impl (#10945 )	2 years ago
thirdparty.inc	Fix build jemalloc api (#5470 )	6 years ago

README.md

RocksDB: A Persistent Key-Value Store for Flash and RAM Storage

RocksDB is developed and maintained by Facebook Database Engineering Team. It is built on earlier work on LevelDB by Sanjay Ghemawat (sanjay@google.com) and Jeff Dean (jeff@google.com)

This code is a library that forms the core building block for a fast key-value server, especially suited for storing data on flash drives. It has a Log-Structured-Merge-Database (LSM) design with flexible tradeoffs between Write-Amplification-Factor (WAF), Read-Amplification-Factor (RAF) and Space-Amplification-Factor (SAF). It has multi-threaded compactions, making it especially suitable for storing multiple terabytes of data in a single database.

Start with example usage here: https://github.com/facebook/rocksdb/tree/main/examples

See the github wiki for more explanation.

The public interface is in include/. Callers should not include or rely on the details of any other header files in this package. Those internal APIs may be changed without warning.

Questions and discussions are welcome on the RocksDB Developers Public Facebook group and email list on Google Groups.

License

RocksDB is dual-licensed under both the GPLv2 (found in the COPYING file in the root directory) and Apache 2.0 License (found in the LICENSE.Apache file in the root directory). You may select, at your option, one of the above-listed licenses.