rocksdb

fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

History

Hui Xiao 2fbe32b0c1 RAII support for per cache reservation through handle (#9130 ) Summary: Note: This PR is the 3rd PR of a bigger PR stack (https://github.com/facebook/rocksdb/issues/9073) and depends on the second PR (https://github.com/facebook/rocksdb/pull/9071). See changes from this PR only `00447324d0` Context: pdillinger brought up a good [point](https://github.com/facebook/rocksdb/pull/9073#discussion_r741478309) about lacking RAII support for per cache reservation in `CacheReservationManager` when reviewing https://github.com/facebook/rocksdb/pull/9073. To summarize the discussion, the current API `CacheReservationManager::UpdateCacheReservation()` requires callers to explicitly calculate and pass in a correct`new_mem_used` to release a cache reservation (if they don't want to rely on the clean-up during `CacheReservationManager`'s destruction - such as they want to release it earlier). While this implementation has convenience in some use-case such as `WriteBufferManager`, where [reservation](https://github.com/facebook/rocksdb/blob/main/memtable/write_buffer_manager.cc#L69-L91) and [release](https://github.com/facebook/rocksdb/blob/main/memtable/write_buffer_manager.cc#L109-L129) amounts do not necessarily correspond symmetrically and thus a flexible `new_mem_used` inputing is needed, it can be prone to caller's calculation error as well as cause a mass of codes in releasing cache in other use-case such as filter construction, where reservation and release amounts do correspond symmetrically and many code paths requiring a cache release, as [pointed](https://github.com/facebook/rocksdb/pull/9073#discussion_r741478309) out by pdillinger. Therefore we decided to provide a new API in `CacheReservationManager` to update reservation with better RAII support for per cache reservation, using a handle to manage the life time of that particular cache reservation. - Added a new class `CacheReservationHandle` - Added a new API `CacheReservationManager::MakeCacheReservation()` that outputs a `CacheReservationHandle` for managing the reservation - Updated class comments to clarify two different cache reservation methods Tests: - Passing new tests Pull Request resolved: https://github.com/facebook/rocksdb/pull/9130 Reviewed By: pdillinger Differential Revision: D32199446 Pulled By: hx235 fbshipit-source-id: 1cba7c636e5ecfb55b0c1e0c2d218cc9b5b30b4e		3 years ago
..
cache.cc	Make SecondaryCache Customizable (#8480 )	3 years ago
cache_bench.cc	Add (& fix) some simple source code checks (#8821 )	3 years ago
cache_bench_tool.cc	Make SecondaryCache Customizable (#8480 )	3 years ago
cache_entry_roles.cc	Account for dictionary-building buffer in global memory limit (#8428 )	3 years ago
cache_entry_roles.h	Account for dictionary-building buffer in global memory limit (#8428 )	3 years ago
cache_entry_stats.h	Fix and detect headers with missing dependencies (#8893 )	3 years ago
cache_helpers.h	Use deleters to label cache entries and collect stats (#8297 )	4 years ago
cache_reservation_manager.cc	RAII support for per cache reservation through handle (#9130 )	3 years ago
cache_reservation_manager.h	RAII support for per cache reservation through handle (#9130 )	3 years ago
cache_reservation_manager_test.cc	RAII support for per cache reservation through handle (#9130 )	3 years ago
cache_test.cc	Use deleters to label cache entries and collect stats (#8297 )	4 years ago
clock_cache.cc	Replace most typedef with using= (#8751 )	3 years ago
clock_cache.h	Change RocksDB License	7 years ago
lru_cache.cc	Fix a race in LRUCacheShard::Promote (#8717 )	3 years ago
lru_cache.h	Add a stat to count secondary cache hits (#8666 )	3 years ago
lru_cache_test.cc	Add lowest_used_cache_tier to ImmutableDBOptions to enable or disable Secondary Cache (#9050 )	3 years ago
sharded_cache.cc	Add a stat to count secondary cache hits (#8666 )	3 years ago
sharded_cache.h	Add a stat to count secondary cache hits (#8666 )	3 years ago