fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Andrew Kryczka d5d8920f2c Fix race condition with WAL tracking and `FlushWAL(true /* sync */)` (#10185) ... Summary: `FlushWAL(true /* sync */)` is used internally and for manual WAL sync. It had a bug when used together with `track_and_verify_wals_in_manifest` where the synced size tracked in MANIFEST was larger than the number of bytes actually synced. The bug could be repro'd almost immediately with the following crash test command: `python3 tools/db_crashtest.py blackbox --simple --write_buffer_size=524288 --max_bytes_for_level_base=2097152 --target_file_size_base=524288 --duration=3600 --interval=10 --sync_fault_injection=1 --disable_wal=0 --checkpoint_one_in=1000 --max_key=10000 --value_size_mult=33`. An example error message produced by the above command is shown below. The error sometimes arose from the checkpoint and other times arose from the main stress test DB. ``` Corruption: Size mismatch: WAL (log number: 119) in MANIFEST is 27938 bytes , but actually is 27859 bytes on disk. ``` Pull Request resolved: https://github.com/facebook/rocksdb/pull/10185 Test Plan: - repro unit test - the above crash test command no longer finds the error. It does find a different error after a while longer such as "Corruption: WAL file 481 required by manifest but not in directory list" Reviewed By: riversand963 Differential Revision: D37200993 Pulled By: ajkr fbshipit-source-id: 98e0071c1a89f4d009888512ed89f9219779ae5f		2 years ago
..
compacted_db_impl.cc	Return "invalid argument" when read timestamp is too old (#10109)	2 years ago
compacted_db_impl.h	Add timestamp support to CompactedDBImpl (#10030)	2 years ago
db_impl.cc	Fix race condition with WAL tracking and `FlushWAL(true /* sync */)` (#10185)	2 years ago
db_impl.h	Fix race condition with WAL tracking and `FlushWAL(true /* sync */)` (#10185)	2 years ago
db_impl_compaction_flush.cc	Fix race condition with WAL tracking and `FlushWAL(true /* sync */)` (#10185)	2 years ago
db_impl_debug.cc	Use std::numeric_limits<> (#9954)	2 years ago
db_impl_experimental.cc	Track SST unique id in MANIFEST and verify (#9990)	2 years ago
db_impl_files.cc	Fix race condition with WAL tracking and `FlushWAL(true /* sync */)` (#10185)	2 years ago
db_impl_open.cc	Add WriteOptions::protection_bytes_per_key (#10037)	2 years ago
db_impl_readonly.cc	Return "invalid argument" when read timestamp is too old (#10109)	2 years ago
db_impl_readonly.h	Add timestamp support to DBImplReadOnly (#10004)	2 years ago
db_impl_secondary.cc	Consolidate manual_compaction_paused_ check (#10070)	2 years ago
db_impl_secondary.h	Persist the new MANIFEST after successfully syncing the new WAL during recovery (#9922)	2 years ago
db_impl_write.cc	Fix race condition with WAL tracking and `FlushWAL(true /* sync */)` (#10185)	2 years ago