You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Igor Canadi
469a9f32a7
Fix two nasty use-after-free-bugs ...
Summary:
These bugs were caught by ASAN crash test.
1. The first one, in table/filter_block.cc is very nasty. We first reference entries_ and store the reference to Slice prev. Then, we call entries_.append(), which can change the reference. The Slice prev now points to junk.
2. The second one is a bug in a test, so it's not very serious. Once we set read_opts.prefix, we never clear it, so some other function might still reference it.
Test Plan: asan crash test now runs more than 5 mins. Before, it failed immediately. I will run the full one, but the full one takes quite some time (5 hours)
Reviewers: dhruba, haobo, kailiu
Reviewed By: dhruba
CC: leveldb
Differential Revision: https://reviews.facebook.net/D14223
11 years ago
..
block.cc
Implement a compressed block cache.
11 years ago
block.h
Implement a compressed block cache.
11 years ago
block_based_table_builder.cc
Improve the "table stats"
11 years ago
block_based_table_builder.h
Implement a compressed block cache.
11 years ago
block_based_table_factory.cc
Follow-up Cleaning-up After D13521
11 years ago
block_based_table_factory.h
Follow-up Cleaning-up After D13521
11 years ago
block_based_table_reader.cc
Improve the "table stats"
11 years ago
block_based_table_reader.h
Improve the "table stats"
11 years ago
block_builder.cc
Make the options in table_builder/block_builder less misleading
11 years ago
block_builder.h
Make the options in table_builder/block_builder less misleading
11 years ago
block_test.cc
Make the options in table_builder/block_builder less misleading
11 years ago
filter_block.cc
Fix two nasty use-after-free-bugs
11 years ago
filter_block.h
Add the index/filter block cache
11 years ago
filter_block_test.cc
Add appropriate LICENSE and Copyright message.
11 years ago
flush_block_policy.cc
Don't not suggest flushing data when data block is still empty
11 years ago
format.cc
Fix stress test failure when using mmap-reads.
11 years ago
format.h
Implement a compressed block cache.
11 years ago
iter_heap.h
Add appropriate LICENSE and Copyright message.
11 years ago
iterator.cc
Add appropriate LICENSE and Copyright message.
11 years ago
iterator_wrapper.h
Add appropriate LICENSE and Copyright message.
11 years ago
merger.cc
Add appropriate LICENSE and Copyright message.
11 years ago
merger.h
Add appropriate LICENSE and Copyright message.
11 years ago
table_reader_bench.cc
Add an option to table_reader_bench to access the table from DB And Iterating non-existing prefix case.
11 years ago
table_test.cc
Improve the "table stats"
11 years ago
two_level_iterator.cc
Fix slow no-io iterator
11 years ago
two_level_iterator.h
Add appropriate LICENSE and Copyright message.
11 years ago
Igor Canadi
469a9f32a7