fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Peter Dillinger 4b86fe1123 Log warning for high bits/key in legacy Bloom filter (#6312) ... Summary: Help users that would benefit most from new Bloom filter implementation by logging a warning that recommends the using format_version >= 5. Pull Request resolved: https://github.com/facebook/rocksdb/pull/6312 Test Plan: $ (for BPK in 10 13 14 19 20 50; do ./filter_bench -quick -impl=0 -bits_per_key=$BPK -m_queries=1 2>&1; done) | grep 'its/key' Bits/key actual: 10.0647 Bits/key actual: 13.0593 [WARN] [/block_based/filter_policy.cc:546] Using legacy Bloom filter with high (14) bits/key. Significant filter space and/or accuracy improvement is available with format_verion>=5. Bits/key actual: 14.0581 [WARN] [/block_based/filter_policy.cc:546] Using legacy Bloom filter with high (19) bits/key. Significant filter space and/or accuracy improvement is available with format_verion>=5. Bits/key actual: 19.0542 [WARN] [/block_based/filter_policy.cc:546] Using legacy Bloom filter with high (20) bits/key. Dramatic filter space and/or accuracy improvement is available with format_verion>=5. Bits/key actual: 20.0584 [WARN] [/block_based/filter_policy.cc:546] Using legacy Bloom filter with high (50) bits/key. Dramatic filter space and/or accuracy improvement is available with format_verion>=5. Bits/key actual: 50.0577 Differential Revision: D19457191 Pulled By: pdillinger fbshipit-source-id: 073d94cde5c70e03a160f953e1100c15ea83eda4		5 years ago
..
block.cc	Fix a bug caused by recent fix of Prefix Hash (#6302)	5 years ago
block.h	Fix kHashSearch bug with SeekForPrev (#6297)	5 years ago
block_based_filter_block.cc	Fix regression affecting partitioned indexes/filters when cache_index_and_filter_blocks is false (#5705)	5 years ago
block_based_filter_block.h	Use delete to disable automatic generated methods. (#5009)	5 years ago
block_based_filter_block_test.cc	Prepare filter tests for more implementations (#5967)	5 years ago
block_based_table_builder.cc	Log warning for high bits/key in legacy Bloom filter (#6312)	5 years ago
block_based_table_builder.h	Expose and elaborate FilterBuildingContext (#6088)	5 years ago
block_based_table_factory.cc	kHashSearch incompatible with index_block_restart_interval>1 (#6294)	5 years ago
block_based_table_factory.h	Organizing rocksdb/table directory by format	6 years ago
block_based_table_reader.cc	Fix another bug caused by recent hash index fix (#6305)	5 years ago
block_based_table_reader.h	Fix kHashSearch bug with SeekForPrev (#6297)	5 years ago
block_builder.cc	Organizing rocksdb/table directory by format	6 years ago
block_builder.h	Organizing rocksdb/table directory by format	6 years ago
block_prefix_index.cc	Move some memory related files from util/ to memory/ (#5382)	6 years ago
block_prefix_index.h	Organizing rocksdb/table directory by format	6 years ago
block_test.cc	upgrade gtest 1.7.0 => 1.8.1 for json result writing	5 years ago
block_type.h	Make the 'block read count' performance counters consistent (#5484)	5 years ago
cachable_entry.h	Move the filter readers out of the block cache (#5504)	5 years ago
data_block_footer.cc	Organizing rocksdb/table directory by format	6 years ago
data_block_footer.h	Organizing rocksdb/table directory by format	6 years ago
data_block_hash_index.cc	Organizing rocksdb/table directory by format	6 years ago
data_block_hash_index.h	Organizing rocksdb/table directory by format	6 years ago
data_block_hash_index_test.cc	Introduce a new storage specific Env API (#5761)	5 years ago
filter_block.h	Apply formatter to recent 200+ commits. (#5830)	5 years ago
filter_block_reader_common.cc	Store the filter bits reader alongside the filter block contents (#5936)	5 years ago
filter_block_reader_common.h	Fix regression affecting partitioned indexes/filters when cache_index_and_filter_blocks is false (#5705)	5 years ago
filter_policy.cc	Log warning for high bits/key in legacy Bloom filter (#6312)	5 years ago
filter_policy_internal.h	Log warning for high bits/key in legacy Bloom filter (#6312)	5 years ago
flush_block_policy.cc	Organizing rocksdb/table directory by format	6 years ago
flush_block_policy.h	Organizing rocksdb/table directory by format	6 years ago
full_filter_block.cc	Store the filter bits reader alongside the filter block contents (#5936)	5 years ago
full_filter_block.h	Store the filter bits reader alongside the filter block contents (#5936)	5 years ago
full_filter_block_test.cc	Expose and elaborate FilterBuildingContext (#6088)	5 years ago
index_builder.cc	kHashSearch incompatible with index_block_restart_interval>1 (#6294)	5 years ago
index_builder.h	Add an option to put first key of each sst block in the index (#5289)	5 years ago
mock_block_based_table.h	Log warning for high bits/key in legacy Bloom filter (#6312)	5 years ago
parsed_full_filter_block.cc	Store the filter bits reader alongside the filter block contents (#5936)	5 years ago
parsed_full_filter_block.h	New Bloom filter implementation for full and partitioned filters (#6007)	5 years ago
partitioned_filter_block.cc	Store the filter bits reader alongside the filter block contents (#5936)	5 years ago
partitioned_filter_block.h	Store the filter bits reader alongside the filter block contents (#5936)	5 years ago
partitioned_filter_block_test.cc	Expose and elaborate FilterBuildingContext (#6088)	5 years ago
uncompression_dict_reader.cc	Apply formatter to recent 200+ commits. (#5830)	5 years ago
uncompression_dict_reader.h	Revert to storing UncompressionDicts in the cache (#5645)	5 years ago