fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Levi Tamasi 2cbb61eadb Make clang-analyzer happy (#5821) ... Summary: clang-analyzer has uncovered a bunch of places where the code is relying on pointers being valid and one case (in VectorIterator) where a moved-from object is being used: In file included from db/range_tombstone_fragmenter.cc:17: ./util/vector_iterator.h:23:18: warning: Method called on moved-from object 'keys' of type 'std::vector' current_(keys.size()) { ^~~~~~~~~~~ 1 warning generated. utilities/persistent_cache/block_cache_tier_file.cc:39:14: warning: Called C++ object pointer is null Status s = env->NewRandomAccessFile(filepath, file, opt); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ utilities/persistent_cache/block_cache_tier_file.cc:47:19: warning: Called C++ object pointer is null Status status = env_->GetFileSize(Path(), size); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ utilities/persistent_cache/block_cache_tier_file.cc:290:14: warning: Called C++ object pointer is null Status s = env_->FileExists(Path()); ^~~~~~~~~~~~~~~~~~~~~~~~ utilities/persistent_cache/block_cache_tier_file.cc:363:35: warning: Called C++ object pointer is null CacheWriteBuffer* const buf = alloc_->Allocate(); ^~~~~~~~~~~~~~~~~~ utilities/persistent_cache/block_cache_tier_file.cc:399:41: warning: Called C++ object pointer is null const uint64_t file_off = buf_doff_ * alloc_->BufferSize(); ^~~~~~~~~~~~~~~~~~~~ utilities/persistent_cache/block_cache_tier_file.cc:463:33: warning: Called C++ object pointer is null size_t start_idx = lba.off_ / alloc_->BufferSize(); ^~~~~~~~~~~~~~~~~~~~ utilities/persistent_cache/block_cache_tier_file.cc:515:5: warning: Called C++ object pointer is null alloc_->Deallocate(bufs_[i]); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ 7 warnings generated. ar: creating librocksdb_debug.a utilities/memory/memory_test.cc:68:25: warning: Called C++ object pointer is null cache_set->insert(db->GetDBOptions().row_cache.get()); ^~~~~~~~~~~~~~~~~~ 1 warning generated. The patch fixes these by adding assertions and explicitly passing in zero when initializing VectorIterator::current_ (which preserves the existing behavior). Pull Request resolved: https://github.com/facebook/rocksdb/pull/5821 Test Plan: Ran make check and make analyze to make sure the warnings have disappeared. Differential Revision: D17455949 Pulled By: ltamasi fbshipit-source-id: 363619618ea649a0674287f9f3b3393e390571ee		5 years ago
..
backupable	Divide file_reader_writer.h and .cc (#5803)	5 years ago
blob_db	Divide file_reader_writer.h and .cc (#5803)	5 years ago
cassandra	Organizing rocksdb/db directory	6 years ago
checkpoint	Export Import sst files (#5495)	5 years ago
compaction_filters	Comment out unused variables	7 years ago
convenience	Auto roll logger to enforce options.keep_log_file_num immediately after a new file is created (#5370)	6 years ago
leveldb_options	Change RocksDB License	7 years ago
memory	Make clang-analyzer happy (#5821)	5 years ago
merge_operators	New API to get all merge operands for a Key (#5604)	5 years ago
option_change_migration	Avoid double-compacting data in bottom level in manual compactions (#5138)	6 years ago
options	simplify include directive involving inttypes (#5402)	6 years ago
persistent_cache	Make clang-analyzer happy (#5821)	5 years ago
simulator_cache	Charge block cache for cache internal usage (#5797)	5 years ago
table_properties_collectors	Reduce the number of random iterations in compact_on_deletion_collector_test (#5635)	5 years ago
trace	Divide file_reader_writer.h and .cc (#5803)	5 years ago
transactions	Refactor ArenaWrappedDBIter into separate files (#5801)	5 years ago
ttl	Fix segfalut in ~DBWithTTLImpl() when called after Close() (#5485)	5 years ago
write_batch_with_index	upgrade gtest 1.7.0 => 1.8.1 for json result writing	5 years ago
debug.cc	Support GetAllKeyVersions() for non-default cf (#5544)	5 years ago
env_librados.cc	Optionally wait on bytes_per_sync to smooth I/O (#5183)	6 years ago
env_librados.md	Add EnvLibrados - RocksDB Env of RADOS (#1222)	8 years ago
env_librados_test.cc	Move test related files under util/ to test_util/ (#5377)	6 years ago
env_mirror.cc	Optionally wait on bytes_per_sync to smooth I/O (#5183)	6 years ago
env_mirror_test.cc	Move test related files under util/ to test_util/ (#5377)	6 years ago
env_timed.cc	Apply modernize-use-override (2nd iteration)	6 years ago
env_timed_test.cc	Move test related files under util/ to test_util/ (#5377)	6 years ago
merge_operators.h	New API to get all merge operands for a Key (#5604)	5 years ago
object_registry.cc	The ObjectRegistry class replaces the Registrar and NewCustomObjects.… (#5293)	5 years ago
object_registry_test.cc	The ObjectRegistry class replaces the Registrar and NewCustomObjects.… (#5293)	5 years ago
util_merge_operators_test.cc	Move test related files under util/ to test_util/ (#5377)	6 years ago