fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Peter Dillinger ffe1e4b820 Make some FilterPolicy deprecations more clear (#9403) ... Summary: The old block-based filter has been deprecated for years, but this makes that more clear by marking the functions specific to it and logging a warning when the feature is used. It is deprecated because of performance. In that old design, you have to binary search through the full SST index before a bloom filter query, which is much more expensive than a bloom query itself. Pull Request resolved: https://github.com/facebook/rocksdb/pull/9403 Test Plan: Used db_bench with and without -use_block_based_filter, running at the same time TEST_TMPDIR=/dev/shm/rocksdb ./db_bench -benchmarks=fillrandom,readrandom -num=10000000 -duration=20 -disable_wal=1 -write_buffer_size=10000000 -bloom_bits=16 -compaction_style=2 -fifo_compaction_max_table_files_size_mb=10000 -fifo_compaction_allow_compaction=0 No significant difference in construction time but 3x slower readrandom with -use_block_based_filter: readrandom : 100.517 micros/op 9948 ops/sec; 1.1 MB/s vs. readrandom : 33.368 micros/op 29968 ops/sec; 3.3 MB/s Also saw deprecation message (just once) in LOG only with -use_block_based_filter Reviewed By: ajkr Differential Revision: D33673202 Pulled By: pdillinger fbshipit-source-id: 99f6f0eff619408d9e5f7ef546954ed0be6c7a5b		3 years ago
..
binary_search_index_reader.cc	Separate internal and user key comparators in `BlockIter` (#6944)	4 years ago
binary_search_index_reader.h	Extend Get/MultiGet deadline support to table open (#6982)	4 years ago
block.cc	Add NewMetaDataIterator method (#8692)	3 years ago
block.h	Add NewMetaDataIterator method (#8692)	3 years ago
block_based_filter_block.cc	Deallocate payload of BlockBasedTableBuilder::Rep::FilterBlockBuilder earlier for Full/PartitionedFilter (#9070)	3 years ago
block_based_filter_block.h	Deallocate payload of BlockBasedTableBuilder::Rep::FilterBlockBuilder earlier for Full/PartitionedFilter (#9070)	3 years ago
block_based_filter_block_test.cc	Add table properties for number of entries added to filters (#8323)	4 years ago
block_based_table_builder.cc	Enable db_test running in Centos 32 bit OS and Alpine 32 bit OS (#9294)	3 years ago
block_based_table_builder.h	Fix segmentation fault in table_options.prepopulate_block_cache when used with partition_filters (#9263)	3 years ago
block_based_table_factory.cc	Enable db_test running in Centos 32 bit OS and Alpine 32 bit OS (#9294)	3 years ago
block_based_table_factory.h	Cleanup includes in dbformat.h (#8930)	3 years ago
block_based_table_iterator.cc	Reuse internal auto readhead_size at each Level (expect L0) for Iterations (#9056)	3 years ago
block_based_table_iterator.h	Fix bug in rocksdb internal automatic prefetching (#9234)	3 years ago
block_based_table_reader.cc	Add NewMetaDataIterator method (#8692)	3 years ago
block_based_table_reader.h	New stable, fixed-length cache keys (#9126)	3 years ago
block_based_table_reader_impl.h	New stable, fixed-length cache keys (#9126)	3 years ago
block_based_table_reader_test.cc	Cleanup includes in dbformat.h (#8930)	3 years ago
block_builder.cc	Improve data block construction performance (#9040)	3 years ago
block_builder.h	Improve data block construction performance (#9040)	3 years ago
block_like_traits.h	fix lru caching test and fix reference binding to null pointer (#8326)	4 years ago
block_prefetcher.cc	Improve / clean up meta block code & integrity (#9163)	3 years ago
block_prefetcher.h	Fix bug in rocksdb internal automatic prefetching (#9234)	3 years ago
block_prefix_index.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
block_prefix_index.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
block_test.cc	Improve / clean up meta block code & integrity (#9163)	3 years ago
block_type.h	Fix and detect headers with missing dependencies (#8893)	3 years ago
cachable_entry.h	Parallelize secondary cache lookup in MultiGet (#8405)	3 years ago
data_block_footer.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
data_block_footer.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
data_block_hash_index.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
data_block_hash_index.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
data_block_hash_index_test.cc	Make it possible to apply only a subrange of table property collectors (#8298)	4 years ago
filter_block.h	Account Bloom/Ribbon filter construction memory in global memory limit (#9073)	3 years ago
filter_block_reader_common.cc	Parallelize secondary cache lookup in MultiGet (#8405)	3 years ago
filter_block_reader_common.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
filter_policy.cc	Make some FilterPolicy deprecations more clear (#9403)	3 years ago
filter_policy_internal.h	Add Bloom/Ribbon hybrid API support (#8679)	3 years ago
flush_block_policy.cc	Restore Regex support for ObjectLibrary::Register, rename new APIs to allow old one to be deprecated in the future (#9362)	3 years ago
flush_block_policy.h	Make FlushBlockPolicyFactory into a Customizable class (#8432)	3 years ago
full_filter_block.cc	Deallocate payload of BlockBasedTableBuilder::Rep::FilterBlockBuilder earlier for Full/PartitionedFilter (#9070)	3 years ago
full_filter_block.h	Account Bloom/Ribbon filter construction memory in global memory limit (#9073)	3 years ago
full_filter_block_test.cc	Add table properties for number of entries added to filters (#8323)	4 years ago
hash_index_reader.cc	Make ImmutableOptions struct that inherits from ImmutableCFOptions and ImmutableDBOptions (#8262)	4 years ago
hash_index_reader.h	Extend Get/MultiGet deadline support to table open (#6982)	4 years ago
index_builder.cc	Add (& fix) some simple source code checks (#8821)	3 years ago
index_builder.h	Make db_basic_test pass assert status checked (#7452)	4 years ago
index_reader_common.cc	Parallelize secondary cache lookup in MultiGet (#8405)	3 years ago
index_reader_common.h	Divide block_based_table_reader.cc (#6527)	5 years ago
mock_block_based_table.h	Make ImmutableOptions struct that inherits from ImmutableCFOptions and ImmutableDBOptions (#8262)	4 years ago
parsed_full_filter_block.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
parsed_full_filter_block.h	Use new Insert and Lookup APIs in table reader to support secondary cache (#8315)	4 years ago
partitioned_filter_block.cc	Improve / clean up meta block code & integrity (#9163)	3 years ago
partitioned_filter_block.h	Deallocate payload of BlockBasedTableBuilder::Rep::FilterBlockBuilder earlier for Full/PartitionedFilter (#9070)	3 years ago
partitioned_filter_block_test.cc	More refactoring ahead of footer & meta changes (#9240)	3 years ago
partitioned_index_iterator.cc	Reuse internal auto readhead_size at each Level (expect L0) for Iterations (#9056)	3 years ago
partitioned_index_iterator.h	Fix bug in rocksdb internal automatic prefetching (#9234)	3 years ago
partitioned_index_reader.cc	Improve / clean up meta block code & integrity (#9163)	3 years ago
partitioned_index_reader.h	Clarify caching behavior for index and filter partitions (#9068)	3 years ago
reader_common.cc	Improve / clean up meta block code & integrity (#9163)	3 years ago
reader_common.h	Bring the Configurable options together (#5753)	4 years ago
uncompression_dict_reader.cc	Cleanup includes in dbformat.h (#8930)	3 years ago
uncompression_dict_reader.h	Extend Get/MultiGet deadline support to table open (#6982)	4 years ago