You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
mrambacher
787229837e
Fix LITE mode builds on MacOs ( #8981 )
...
Summary:
On MacOS, there were errors building in LITE mode related to unused private member variables:
In file included from ./db/compaction/compaction_job.h:20:
./db/blob/blob_file_completion_callback.h:87:19: error: private field ‘sst_file_manager_’ is not used [-Werror,-Wunused-private-field]
SstFileManager* sst_file_manager_;
^
./db/blob/blob_file_completion_callback.h:88:22: error: private field ‘mutex_’ is not used [-Werror,-Wunused-private-field]
InstrumentedMutex* mutex_;
^
./db/blob/blob_file_completion_callback.h:89:17: error: private field ‘error_handler_’ is not used [-Werror,-Wunused-private-field]
ErrorHandler* error_handler_;
This PR resolves those build issues by removing the values as members in LITE mode and fixing the constructor to ignore the input values in LITE mode (otherwise we get unused parameter warnings).
Tested by validating compiles without warnings.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/8981
Reviewed By: akankshamahajan15
Differential Revision: D31320141
Pulled By: mrambacher
fbshipit-source-id: d67875ebbd39a9555e4f09b2d37159566dd8a085
3 years ago
..
blob_constants.h
Move BlobDB related files under db/ to db/blob/ ( #6519 )
5 years ago
blob_counting_iterator.h
Log the amount of blob garbage generated by compactions in the MANIFEST ( #8450 )
4 years ago
blob_counting_iterator_test.cc
Add an internal iterator that can measure the inflow of blobs ( #8443 )
4 years ago
blob_fetcher.cc
Support for Merge in Integrated BlobDB with base values ( #8292 )
4 years ago
blob_fetcher.h
Support for Merge in Integrated BlobDB with base values ( #8292 )
4 years ago
blob_file_addition.cc
Print blob file checksums as hex ( #8437 )
4 years ago
blob_file_addition.h
Move BlobDB related files under db/ to db/blob/ ( #6519 )
5 years ago
blob_file_addition_test.cc
Print blob file checksums as hex ( #8437 )
4 years ago
blob_file_builder.cc
Expose blob file information through the EventListener interface ( #8675 )
3 years ago
blob_file_builder.h
Expose blob file information through the EventListener interface ( #8675 )
3 years ago
blob_file_builder_test.cc
Make SystemClock into a Customizable Class ( #8636 )
3 years ago
blob_file_cache.cc
Rename ImmutableOptions variables ( #8409 )
4 years ago
blob_file_cache.h
Rename ImmutableOptions variables ( #8409 )
4 years ago
blob_file_cache_test.cc
Make SystemClock into a Customizable Class ( #8636 )
3 years ago
blob_file_completion_callback.h
Fix LITE mode builds on MacOs ( #8981 )
3 years ago
blob_file_garbage.cc
Move BlobDB related files under db/ to db/blob/ ( #6519 )
5 years ago
blob_file_garbage.h
Move BlobDB related files under db/ to db/blob/ ( #6519 )
5 years ago
blob_file_garbage_test.cc
Move BlobDB related files under db/ to db/blob/ ( #6519 )
5 years ago
blob_file_meta.cc
Add BlobMetaData retrieval methods ( #8273 )
4 years ago
blob_file_meta.h
Add BlobMetaData retrieval methods ( #8273 )
4 years ago
blob_file_reader.cc
Add comments for MultiGetBlob() and checks for MultiRead() ( #8972 )
3 years ago
blob_file_reader.h
Add comments for MultiGetBlob() and checks for MultiRead() ( #8972 )
3 years ago
blob_file_reader_test.cc
Make SystemClock into a Customizable Class ( #8636 )
3 years ago
blob_garbage_meter.cc
Add a class for measuring the amount of garbage generated during compaction ( #8426 )
4 years ago
blob_garbage_meter.h
Add a class for measuring the amount of garbage generated during compaction ( #8426 )
4 years ago
blob_garbage_meter_test.cc
Add a class for measuring the amount of garbage generated during compaction ( #8426 )
4 years ago
blob_index.h
Batch blob read IO for MultiGet ( #8699 )
3 years ago
blob_log_format.cc
Introduce BlobFileCache and add support for blob files to Get() ( #7540 )
4 years ago
blob_log_format.h
Add a class for measuring the amount of garbage generated during compaction ( #8426 )
4 years ago
blob_log_sequential_reader.cc
Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines ( #8033 )
4 years ago
blob_log_sequential_reader.h
Fix a issue with initializing blob header buffer ( #8537 )
3 years ago
blob_log_writer.cc
Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines ( #8033 )
4 years ago
blob_log_writer.h
Use SystemClock* instead of std::shared_ptr<SystemClock> in lower level routines ( #8033 )
4 years ago
db_blob_basic_test.cc
Sort per-file blob read requests by offset ( #8953 )
3 years ago
db_blob_compaction_test.cc
Support custom env in db_blob_{basic,compaction,corruption,index}_test ( #8817 )
3 years ago
db_blob_corruption_test.cc
Support custom env in db_blob_{basic,compaction,corruption,index}_test ( #8817 )
3 years ago
db_blob_index_test.cc
Support custom env in db_blob_{basic,compaction,corruption,index}_test ( #8817 )
3 years ago