fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Zhongyi Xie 80bc35927c Should only decode restart points for uncompressed blocks (#3996) ... Summary: The Block object assumes contents are uncompressed. Block's constructor tries to read the number of restarts, but does not get an accurate number when its contents are compressed, which is causing issues like https://github.com/facebook/rocksdb/issues/3843. This PR address this issue by skipping reconstruction of restart points when blocks are known to be compressed. Somehow the restart points can be read directly when Snappy is used and some tests (for example https://github.com/facebook/rocksdb/blob/master/db/db_block_cache_test.cc#L196) expects blocks to be fully constructed even when Snappy compression is used, so here we keep the restart point logic for Snappy. Closes https://github.com/facebook/rocksdb/pull/3996 Differential Revision: D8416186 Pulled By: miasantreble fbshipit-source-id: 002c0b62b9e5d89fb7736563d354ce0023c8cb28		7 years ago
..
adaptive_table_factory.cc	Comment out unused variables	7 years ago
adaptive_table_factory.h	Comment out unused variables	7 years ago
block.cc	Should only decode restart points for uncompressed blocks (#3996)	7 years ago
block.h	Fix performance regression in Get() for block-based tables (#3953)	7 years ago
block_based_filter_block.cc	Move prefix_extractor to MutableCFOptions	7 years ago
block_based_filter_block.h	Move prefix_extractor to MutableCFOptions	7 years ago
block_based_filter_block_test.cc	Move prefix_extractor to MutableCFOptions	7 years ago
block_based_table_builder.cc	run make format for PR 3838 (#3954)	7 years ago
block_based_table_builder.h	run make format for PR 3838 (#3954)	7 years ago
block_based_table_factory.cc	Move prefix_extractor to MutableCFOptions	7 years ago
block_based_table_factory.h	Align SST file data blocks to avoid spanning multiple pages	7 years ago
block_based_table_reader.cc	Should only decode restart points for uncompressed blocks (#3996)	7 years ago
block_based_table_reader.h	Exclude seq from index keys	7 years ago
block_builder.cc	Change RocksDB License	8 years ago
block_builder.h	Change RocksDB License	8 years ago
block_fetcher.cc	run make format for PR 3838 (#3954)	7 years ago
block_fetcher.h	Fix BlockFetcher ASAN error	7 years ago
block_prefix_index.cc	Change RocksDB License	8 years ago
block_prefix_index.h	Change RocksDB License	8 years ago
block_test.cc	Exclude seq from index keys	7 years ago
bloom_block.cc	Change RocksDB License	8 years ago
bloom_block.h	Change RocksDB License	8 years ago
cleanable_test.cc	Change RocksDB License	8 years ago
cuckoo_table_builder.cc	Enable MSVC W4 with a few exceptions. Fix warnings and bugs	7 years ago
cuckoo_table_builder.h	Change RocksDB License	8 years ago
cuckoo_table_builder_test.cc	Should only decode restart points for uncompressed blocks (#3996)	7 years ago
cuckoo_table_factory.cc	Comment out unused variables	7 years ago
cuckoo_table_factory.h	comment unused parameters to turn on -Wunused-parameter flag	7 years ago
cuckoo_table_reader.cc	Should only decode restart points for uncompressed blocks (#3996)	7 years ago
cuckoo_table_reader.h	Move prefix_extractor to MutableCFOptions	7 years ago
cuckoo_table_reader_test.cc	Move prefix_extractor to MutableCFOptions	7 years ago
filter_block.h	Move prefix_extractor to MutableCFOptions	7 years ago
flush_block_policy.cc	Align SST file data blocks to avoid spanning multiple pages	7 years ago
format.cc	run make format for PR 3838 (#3954)	7 years ago
format.h	run make format for PR 3838 (#3954)	7 years ago
full_filter_bits_builder.h	Skip duplicate bloom keys when whole_key and prefix are mixed	7 years ago
full_filter_block.cc	Move prefix_extractor to MutableCFOptions	7 years ago
full_filter_block.h	Move prefix_extractor to MutableCFOptions	7 years ago
full_filter_block_test.cc	Move prefix_extractor to MutableCFOptions	7 years ago
get_context.cc	comment unused parameters to turn on -Wunused-parameter flag	7 years ago
get_context.h	Stats for false positive rate of full filtesr	7 years ago
index_builder.cc	Extend format 3 to partitioned index/filters (#3958)	7 years ago
index_builder.h	Extend format 3 to partitioned index/filters (#3958)	7 years ago
internal_iterator.h	Change and clarify the relationship between Valid(), status() and Seek*() for all iterators. Also fix some bugs	7 years ago
iter_heap.h	Make InternalKeyComparator final and directly use it in merging iterator	7 years ago
iterator.cc	Comment out unused variables	7 years ago
iterator_wrapper.h	Change and clarify the relationship between Valid(), status() and Seek*() for all iterators. Also fix some bugs	7 years ago
merger_test.cc	Make InternalKeyComparator final and directly use it in merging iterator	7 years ago
merging_iterator.cc	Fix regression bug of Prev() with upper bound (#3989)	7 years ago
merging_iterator.h	fix DBImpl::NewInternalIterator super-version leak on failure	7 years ago
meta_blocks.cc	Should only decode restart points for uncompressed blocks (#3996)	7 years ago
meta_blocks.h	Should only decode restart points for uncompressed blocks (#3996)	7 years ago
mock_table.cc	Move prefix_extractor to MutableCFOptions	7 years ago
mock_table.h	Move prefix_extractor to MutableCFOptions	7 years ago
partitioned_filter_block.cc	Extend format 3 to partitioned index/filters (#3958)	7 years ago
partitioned_filter_block.h	Extend format 3 to partitioned index/filters (#3958)	7 years ago
partitioned_filter_block_test.cc	Extend format 3 to partitioned index/filters (#3958)	7 years ago
persistent_cache_helper.cc	comment unused parameters to turn on -Wunused-parameter flag	7 years ago
persistent_cache_helper.h	Change RocksDB License	8 years ago
persistent_cache_options.h	Change RocksDB License	8 years ago
plain_table_builder.cc	Move prefix_extractor to MutableCFOptions	7 years ago
plain_table_builder.h	Move prefix_extractor to MutableCFOptions	7 years ago
plain_table_factory.cc	Move prefix_extractor to MutableCFOptions	7 years ago
plain_table_factory.h	Comment out unused variables	7 years ago
plain_table_index.cc	Change RocksDB License	8 years ago
plain_table_index.h	Move prefix_extractor to MutableCFOptions	7 years ago
plain_table_key_coding.cc	Comment out unused variables	7 years ago
plain_table_key_coding.h	Change RocksDB License	8 years ago
plain_table_reader.cc	Should only decode restart points for uncompressed blocks (#3996)	7 years ago
plain_table_reader.h	Move prefix_extractor to MutableCFOptions	7 years ago
scoped_arena_iterator.h	Change RocksDB License	8 years ago
sst_file_writer.cc	Move prefix_extractor to MutableCFOptions	7 years ago
sst_file_writer_collectors.h	Comment out unused variables	7 years ago
table_builder.h	Move prefix_extractor to MutableCFOptions	7 years ago
table_properties.cc	Exclude seq from index keys	7 years ago
table_properties_internal.h	Eliminate some redundant block reads.	7 years ago
table_reader.h	Move prefix_extractor to MutableCFOptions	7 years ago
table_reader_bench.cc	Move prefix_extractor to MutableCFOptions	7 years ago
table_test.cc	Should only decode restart points for uncompressed blocks (#3996)	7 years ago
two_level_iterator.cc	Change and clarify the relationship between Valid(), status() and Seek*() for all iterators. Also fix some bugs	7 years ago
two_level_iterator.h	fix memory leak in two_level_iterator	7 years ago