fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Peter Dillinger fc9d4071f0 Fast path for detecting unchanged prefix_extractor (#9407) ... Summary: Fixes a major performance regression in 6.26, where extra CPU is spent in SliceTransform::AsString when reads involve a prefix_extractor (Get, MultiGet, Seek). Common case performance is now better than 6.25. This change creates a "fast path" for verifying that the current prefix extractor is unchanged and compatible with what was used to generate a table file. This fast path detects the common case by pointer comparison on the current prefix_extractor and a "known good" prefix extractor (if applicable) that is saved at the time the table reader is opened. The "known good" prefix extractor is saved as another shared_ptr copy (in an existing field, however) to ensure the pointer is not recycled. When the prefix_extractor has changed to a different instance but same compatible configuration (rare, odd), performance is still a regression compared to 6.25, but this is likely acceptable because of the oddity of such a case. The performance of incompatible prefix_extractor is essentially unchanged. Also fixed a minor case (ForwardIterator) where a prefix_extractor could be used via a raw pointer after being freed as a shared_ptr, if replaced via SetOptions. Pull Request resolved: https://github.com/facebook/rocksdb/pull/9407 Test Plan: ## Performance Populate DB with `TEST_TMPDIR=/dev/shm/rocksdb ./db_bench -benchmarks=fillrandom -num=10000000 -disable_wal=1 -write_buffer_size=10000000 -bloom_bits=16 -compaction_style=2 -fifo_compaction_max_table_files_size_mb=10000 -fifo_compaction_allow_compaction=0 -prefix_size=12` Running head-to-head comparisons simultaneously with `TEST_TMPDIR=/dev/shm/rocksdb ./db_bench -use_existing_db -readonly -benchmarks=seekrandom -num=10000000 -duration=20 -disable_wal=1 -bloom_bits=16 -compaction_style=2 -fifo_compaction_max_table_files_size_mb=10000 -fifo_compaction_allow_compaction=0 -prefix_size=12` Below each is compared by ops/sec vs. baseline which is version 6.25 (multiple baseline runs because of variable machine load) v6.26: 4833 vs. 6698 (<- major regression!) v6.27: 4737 vs. 6397 (still) New: 6704 vs. 6461 (better than baseline in common case) Disabled fastpath: 4843 vs. 6389 (e.g. if prefix extractor instance changes but is still compatible) Changed prefix size (no usable filter) in new: 787 vs. 5927 Changed prefix size (no usable filter) in new & baseline: 773 vs. 784 Reviewed By: mrambacher Differential Revision: D33677812 Pulled By: pdillinger fbshipit-source-id: 571d9711c461fb97f957378a061b7e7dbc4d6a76		3 years ago
..
clipping_iterator.h	Add a clipping internal iterator (#8327)	3 years ago
clipping_iterator_test.cc	Cleanup multiple implementations of VectorIterator (#8901)	3 years ago
compaction.cc	Try to start TTL earlier with kMinOverlappingRatio is used (#8749)	3 years ago
compaction.h	Try to start TTL earlier with kMinOverlappingRatio is used (#8749)	3 years ago
compaction_iteration_stats.h	Support readahead during compaction for blob files (#9187)	3 years ago
compaction_iterator.cc	Support readahead during compaction for blob files (#9187)	3 years ago
compaction_iterator.h	Support readahead during compaction for blob files (#9187)	3 years ago
compaction_iterator_test.cc	Support readahead during compaction for blob files (#9187)	3 years ago
compaction_job.cc	Fast path for detecting unchanged prefix_extractor (#9407)	3 years ago
compaction_job.h	Cleanup includes in dbformat.h (#8930)	3 years ago
compaction_job_stats_test.cc	Make MemTableRepFactory into a Customizable class (#8419)	3 years ago
compaction_job_test.cc	File temperature information should be preserved when restart the DB (#9242)	3 years ago
compaction_picker.cc	Ignore non-overlapping levels when determinig grandparent files (#9051)	3 years ago
compaction_picker.h	Make ImmutableOptions struct that inherits from ImmutableCFOptions and ImmutableDBOptions (#8262)	4 years ago
compaction_picker_fifo.cc	Cleanup includes in dbformat.h (#8930)	3 years ago
compaction_picker_fifo.h	Move old files to warm tier in FIFO compactions (#8310)	3 years ago
compaction_picker_level.cc	Make it possible to force the garbage collection of the oldest blob files (#8994)	3 years ago
compaction_picker_level.h	Make ImmutableOptions struct that inherits from ImmutableCFOptions and ImmutableDBOptions (#8262)	4 years ago
compaction_picker_test.cc	Fix clang13 build error (#9374)	3 years ago
compaction_picker_universal.cc	Fix num files in single compaction for universal compaction (#9168)	3 years ago
compaction_picker_universal.h	Make ImmutableOptions struct that inherits from ImmutableCFOptions and ImmutableDBOptions (#8262)	4 years ago
compaction_service_test.cc	Enable a few unit tests to use custom Env objects (#9087)	3 years ago
file_pri.h	Try to start TTL earlier with kMinOverlappingRatio is used (#8749)	3 years ago
sst_partitioner.cc	Restore Regex support for ObjectLibrary::Register, rename new APIs to allow old one to be deprecated in the future (#9362)	3 years ago