rocksdb

fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

History

Andrew Kryczka 82611ee25a save key comparisons in BlockIter::BinarySeek (#7068 ) Summary: This is a followup to https://github.com/facebook/rocksdb/issues/6646. In that PR, for simplicity I just appended a comparison against the 0th restart key in case `BinarySeek()`'s binary search landed at index 0. As a result there were `2/(N+1) + log_2(N)` key comparisons. This PR does it differently. Now we expand the binary search range by one so it also covers the case where target is at or before the restart key at index 0. As a result, it involves `log_2(N+1)` key comparisons. Pull Request resolved: https://github.com/facebook/rocksdb/pull/7068 Test Plan: ran readrandom with mostly default settings and counted key comparisons using `PerfContext`. before: `user_key_comparison_count = 28881965` after: `user_key_comparison_count = 27823245` setup command: ``` $ TEST_TMPDIR=/dev/shm/dbbench ./db_bench -benchmarks=fillrandom,compact -write_buffer_size=1048576 -target_file_size_base=1048576 -max_bytes_for_level_base=4194304 -max_background_jobs=12 -level_compaction_dynamic_level_bytes=true -num=10000000 ``` benchmark command: ``` $ TEST_TMPDIR=/dev/shm/dbbench/ ./db_bench -use_existing_db=true -benchmarks=readrandom -disable_auto_compactions=true -num=10000000 -compression_type=none -reads=1000000 -perf_level=3 ``` Reviewed By: anand1976 Differential Revision: D22357032 Pulled By: ajkr fbshipit-source-id: 8b01e9c1c2a4e9d02fc9dfe16c1cc0327f8bdf24		4 years ago
..
binary_search_index_reader.cc	Separate internal and user key comparators in `BlockIter` (#6944 )	4 years ago
binary_search_index_reader.h	Extend Get/MultiGet deadline support to table open (#6982 )	4 years ago
block.cc	save key comparisons in BlockIter::BinarySeek (#7068 )	4 years ago
block.h	save key comparisons in BlockIter::BinarySeek (#7068 )	4 years ago
block_based_filter_block.cc	Extend Get/MultiGet deadline support to table open (#6982 )	4 years ago
block_based_filter_block.h	Extend Get/MultiGet deadline support to table open (#6982 )	4 years ago
block_based_filter_block_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	5 years ago
block_based_table_builder.cc	Fix block checksum for >=4GB, refactor (#6978 )	4 years ago
block_based_table_builder.h	Store DB identity and DB session ID in SST files (#6983 )	4 years ago
block_based_table_factory.cc	Extend Get/MultiGet deadline support to table open (#6982 )	4 years ago
block_based_table_factory.h	Extend Get/MultiGet deadline support to table open (#6982 )	4 years ago
block_based_table_iterator.cc	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621 )	5 years ago
block_based_table_iterator.h	Properly report IO errors when IndexType::kBinarySearchWithFirstKey is used (#6621 )	5 years ago
block_based_table_reader.cc	Separate internal and user key comparators in `BlockIter` (#6944 )	4 years ago
block_based_table_reader.h	Extend Get/MultiGet deadline support to table open (#6982 )	4 years ago
block_based_table_reader_impl.h	Divide block_based_table_reader.cc (#6527 )	5 years ago
block_based_table_reader_test.cc	Extend Get/MultiGet deadline support to table open (#6982 )	4 years ago
block_builder.cc	Add pipelined & parallel compression optimization (#6262 )	5 years ago
block_builder.h	Add pipelined & parallel compression optimization (#6262 )	5 years ago
block_prefetcher.cc	De-template block based table iterator (#6531 )	5 years ago
block_prefetcher.h	De-template block based table iterator (#6531 )	5 years ago
block_prefix_index.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	5 years ago
block_prefix_index.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	5 years ago
block_test.cc	Separate internal and user key comparators in `BlockIter` (#6944 )	4 years ago
block_type.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	5 years ago
cachable_entry.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	5 years ago
data_block_footer.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	5 years ago
data_block_footer.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	5 years ago
data_block_hash_index.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	5 years ago
data_block_hash_index.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	5 years ago
data_block_hash_index_test.cc	Separate internal and user key comparators in `BlockIter` (#6944 )	4 years ago
filter_block.h	Extend Get/MultiGet deadline support to table open (#6982 )	4 years ago
filter_block_reader_common.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	5 years ago
filter_block_reader_common.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	5 years ago
filter_policy.cc	Add unity build to CircleCI (#7026 )	4 years ago
filter_policy_internal.h	Minimize memory internal fragmentation for Bloom filters (#6427 )	4 years ago
flush_block_policy.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	5 years ago
flush_block_policy.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	5 years ago
full_filter_block.cc	Extend Get/MultiGet deadline support to table open (#6982 )	4 years ago
full_filter_block.h	Extend Get/MultiGet deadline support to table open (#6982 )	4 years ago
full_filter_block_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	5 years ago
hash_index_reader.cc	Separate internal and user key comparators in `BlockIter` (#6944 )	4 years ago
hash_index_reader.h	Extend Get/MultiGet deadline support to table open (#6982 )	4 years ago
index_builder.cc	Update Flush policy in PartitionedIndexBuilder on switching from user-key to internal-key mode (#7096 )	4 years ago
index_builder.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	5 years ago
index_reader_common.cc	Divide block_based_table_reader.cc (#6527 )	5 years ago
index_reader_common.h	Divide block_based_table_reader.cc (#6527 )	5 years ago
mock_block_based_table.h	For ApproximateSizes, pro-rate table metadata size over data blocks (#6784 )	4 years ago
parsed_full_filter_block.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	5 years ago
parsed_full_filter_block.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433 )	5 years ago
partitioned_filter_block.cc	Separate internal and user key comparators in `BlockIter` (#6944 )	4 years ago
partitioned_filter_block.h	Extend Get/MultiGet deadline support to table open (#6982 )	4 years ago
partitioned_filter_block_test.cc	Revert "Update googletest from 1.8.1 to 1.10.0 (#6808 )" (#6923 )	4 years ago
partitioned_index_iterator.cc	Fix regression bug in partitioned index reseek caused by #6531 (#6551 )	5 years ago
partitioned_index_iterator.h	Check iterator status BlockBasedTableReader::VerifyChecksumInBlocks() (#6909 )	4 years ago
partitioned_index_reader.cc	Separate internal and user key comparators in `BlockIter` (#6944 )	4 years ago
partitioned_index_reader.h	Extend Get/MultiGet deadline support to table open (#6982 )	4 years ago
reader_common.cc	Fix block checksum for >=4GB, refactor (#6978 )	4 years ago
reader_common.h	Fix block checksum for >=4GB, refactor (#6978 )	4 years ago
uncompression_dict_reader.cc	Extend Get/MultiGet deadline support to table open (#6982 )	4 years ago
uncompression_dict_reader.h	Extend Get/MultiGet deadline support to table open (#6982 )	4 years ago