fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

anand76 a9d168cfd7 Simplify migration to FileSystem API (#6552) ... Summary: The current Env/FileSystem API separation has a couple of issues - 1. It requires the user to specify 2 options - ```Options::env``` and ```Options::file_system``` - which means they have to make code changes to benefit from the new APIs. Furthermore, there is a risk of accessing the same APIs in two different ways, through Env in the old way and through FileSystem in the new way. The two may not always match, for example, if env is ```PosixEnv``` and FileSystem is a custom implementation. Any stray RocksDB calls to env will use the ```PosixEnv``` implementation rather than the file_system implementation. 2. There needs to be a simple way for the FileSystem developer to instantiate an Env for backward compatibility purposes. This PR solves the above issues and simplifies the migration in the following ways - 1. Embed a shared_ptr to the ```FileSystem``` in the ```Env```, and remove ```Options::file_system``` as a configurable option. This way, no code changes will be required in application code to benefit from the new API. The default Env constructor uses a ```LegacyFileSystemWrapper``` as the embedded ```FileSystem```. 1a. - This also makes it more robust by ensuring that even if RocksDB has some stray calls to Env APIs rather than FileSystem, they will go through the same object and thus there is no risk of getting out of sync. 2. Provide a ```NewCompositeEnv()``` API that can be used to construct a PosixEnv with a custom FileSystem implementation. This eliminates an indirection to call Env APIs, and relieves the FileSystem developer of the burden of having to implement wrappers for the Env APIs. 3. Add a couple of missing FileSystem APIs - ```SanitizeEnvOptions()``` and ```NewLogger()``` Tests: 1. New unit tests 2. make check and make asan_check Pull Request resolved: https://github.com/facebook/rocksdb/pull/6552 Reviewed By: riversand963 Differential Revision: D20592038 Pulled By: anand1976 fbshipit-source-id: c3801ad4153f96d21d5a3ae26c92ba454d1bf1f7		5 years ago
..
composite_env_wrapper.h	Simplify migration to FileSystem API (#6552)	5 years ago
env.cc	Simplify migration to FileSystem API (#6552)	5 years ago
env_basic_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
env_chroot.cc	Cache result of GetLogicalBufferSize in Linux (#6457)	5 years ago
env_chroot.h	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
env_encryption.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
env_hdfs.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago
env_posix.cc	Simplify migration to FileSystem API (#6552)	5 years ago
env_test.cc	Simplify migration to FileSystem API (#6552)	5 years ago
file_system.cc	Simplify migration to FileSystem API (#6552)	5 years ago
fs_posix.cc	Simplify migration to FileSystem API (#6552)	5 years ago
io_posix.cc	Cache result of GetLogicalBufferSize in Linux (#6457)	5 years ago
io_posix.h	Cache result of GetLogicalBufferSize in Linux (#6457)	5 years ago
io_posix_test.cc	Cache result of GetLogicalBufferSize in Linux (#6457)	5 years ago
mock_env.cc	Attempt to recover from db with missing table files (#6334)	5 years ago
mock_env.h	Attempt to recover from db with missing table files (#6334)	5 years ago
mock_env_test.cc	Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE (#6433)	5 years ago