fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Peter Dillinger 7555243bcf Refactor ShardedCache for more sharing, static polymorphism (#10801) ... Summary: The motivations for this change include * Free up space in ClockHandle so that we can add data for secondary cache handling while still keeping within single cache line (64 byte) size. * This change frees up space by eliminating the need for the `hash` field by making the fixed-size key itself a hash, using a 128-bit bijective (lossless) hash. * Generally more customizability of ShardedCache (such as hashing) without worrying about virtual call overheads * ShardedCache now uses static polymorphism (template) instead of dynamic polymorphism (virtual overrides) for the CacheShard. No obvious performance benefit is seen from the change (as mostly expected; most calls to virtual functions in CacheShard could already be optimized to static calls), but offers more flexibility without incurring the runtime cost of adhering to a common interface (without type parameters or static callbacks). * You'll also notice less `reinterpret_cast`ing and other boilerplate in the Cache implementations, as this can go in ShardedCache. More detail: * Don't have LRUCacheShard maintain `std::shared_ptr<SecondaryCache>` copies (extra refcount) when LRUCache can be in charge of keeping a `shared_ptr`. * Renamed `capacity_mutex_` to `config_mutex_` to better represent the scope of what it guards. * Some preparation for 64-bit hash and indexing in LRUCache, but didn't include the full change because of slight performance regression. Pull Request resolved: https://github.com/facebook/rocksdb/pull/10801 Test Plan: Unit test updates were non-trivial because of major changes to the ClockCacheShard interface in handling of key vs. hash. Performance: Create with `TEST_TMPDIR=/dev/shm ./db_bench -benchmarks=fillrandom -num=30000000 -disable_wal=1 -bloom_bits=16` Test with ``` TEST_TMPDIR=/dev/shm ./db_bench -benchmarks=readrandom[-X1000] -readonly -num=30000000 -bloom_bits=16 -cache_index_and_filter_blocks=1 -cache_size=610000000 -duration 20 -threads=16 ``` Before: `readrandom [AVG 150 runs] : 321147 (± 253) ops/sec` After: `readrandom [AVG 150 runs] : 321530 (± 326) ops/sec` So possibly ~0.1% improvement. And with `-cache_type=hyper_clock_cache`: Before: `readrandom [AVG 30 runs] : 614126 (± 7978) ops/sec` After: `readrandom [AVG 30 runs] : 645349 (± 8087) ops/sec` So roughly 5% improvement! Reviewed By: anand1976 Differential Revision: D40252236 Pulled By: pdillinger fbshipit-source-id: ff8fc70ef569585edc95bcbaaa0386f61355ae5b		2 years ago
..
cf_options.cc	Add option `preserve_internal_time_seconds` to preserve the time info (#10747)	2 years ago
cf_options.h	Add option `preserve_internal_time_seconds` to preserve the time info (#10747)	2 years ago
configurable.cc	Option type info functions (#9411)	3 years ago
configurable_helper.h	Fix some minor issues in the Customizable infrastructure (#8566)	3 years ago
configurable_test.cc	Print stack traces on frozen tests in CI (#10828)	2 years ago
configurable_test.h	Move RegisterOptions into the Configurable API (#8223)	4 years ago
customizable.cc	Option type info functions (#9411)	3 years ago
customizable_test.cc	Avoid recompressing cold block in CompressedSecondaryCache (#10527)	2 years ago
db_options.cc	Make RateLimiter not Customizable (#10378)	2 years ago
db_options.h	Dynamically changeable `MemPurge` option (#10011)	3 years ago
options.cc	Add option `preserve_internal_time_seconds` to preserve the time info (#10747)	2 years ago
options_helper.cc	Add option `preserve_internal_time_seconds` to preserve the time info (#10747)	2 years ago
options_helper.h	Support prepopulating/warming the blob cache (#10298)	2 years ago
options_parser.cc	fix a false positive case of parsing table factory from options file (#10094)	3 years ago
options_parser.h	Bring the Configurable options together (#5753)	4 years ago
options_settable_test.cc	Print stack traces on frozen tests in CI (#10828)	2 years ago
options_test.cc	Refactor ShardedCache for more sharing, static polymorphism (#10801)	2 years ago