You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Cheng Chang
b2e30bdb67
Get manifest size again after getting min_log_num during checkpoint ( #7836 )
...
Summary:
Currently, manifest size is determined before getting min_log_num.
But between getting manifest size and getting min_log_num, concurrently, a flush might succeed, which will write new records to manifest to make some WALs become outdated, then min_log_num will be correspondingly increased, but the new records in manifest will not be copied into the checkpoint because the manifest's size is determined before them, then the newly outdated WALs will still exist in the checkpoint's manifest, but they are not linked/copied to the checkpoint because their log number is < min_log_num, so a corruption of missing WAL will be reported when restoring from the checkpoint.
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7836
Test Plan: make crash_test
Reviewed By: ajkr
Differential Revision: D25788204
Pulled By: cheng-chang
fbshipit-source-id: a4e5acf30f08270b3c0a95304ff559a9e655252f
4 years ago
..
backupable
Add more tests to the ASC pass list ( #7834 )
4 years ago
blob_db
Add more tests to the ASC pass list ( #7834 )
4 years ago
cassandra
Add more tests for assert status checked ( #7524 )
4 years ago
checkpoint
Get manifest size again after getting min_log_num during checkpoint ( #7836 )
4 years ago
compaction_filters
Compaction filter support for BlobDB ( #6850 )
5 years ago
convenience
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
leveldb_options
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
memory
No elide constructors ( #7798 )
4 years ago
merge_operators
No elide constructors ( #7798 )
4 years ago
option_change_migration
Add more tests for assert status checked ( #7524 )
4 years ago
options
Create a CustomEnv class; Add WinFileSystem; Make LegacyFileSystemWrapper private ( #7703 )
4 years ago
persistent_cache
Fix many tests to run with MEM_ENV and ENCRYPTED_ENV; Introduce a MemoryFileSystem class ( #7566 )
4 years ago
simulator_cache
Bring the Configurable options together ( #5753 )
4 years ago
table_properties_collectors
Add more tests for assert status checked ( #7524 )
4 years ago
trace
Add some simulator cache and block tracer tests to ASSERT_STATUS_CHECKED ( #7305 )
4 years ago
transactions
Disable BasicLockEscalation if cannot determine whether TSAN is enabled ( #7814 )
4 years ago
ttl
Add more tests to the ASC pass list ( #7834 )
4 years ago
write_batch_with_index
Eliminate the creation of ImmutableDBOptions in WBWI::GetFromBatch ( #6851 )
4 years ago
debug.cc
In ParseInternalKey(), include corrupt key info in Status ( #7515 )
4 years ago
env_librados.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
env_librados.md
Add EnvLibrados - RocksDB Env of RADOS ( #1222 )
9 years ago
env_librados_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
env_mirror.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
env_mirror_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
env_timed.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
env_timed_test.cc
Make env*_test work with ASSERT_STATUS_CHECKED ( #7176 )
4 years ago
fault_injection_env.cc
No elide constructors ( #7798 )
4 years ago
fault_injection_env.h
Status check enforcement for error_handler_fs_test ( #7342 )
4 years ago
fault_injection_fs.cc
fix typo ( #7832 )
4 years ago
fault_injection_fs.h
Inject the random write error to stress test ( #7653 )
4 years ago
merge_operators.h
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
object_registry.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
object_registry_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
util_merge_operators_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago