fork of https://github.com/oxigraph/rocksdb and https://github.com/facebook/rocksdb for nextgraph and oxigraph

You can not select more than 25 topics Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.

Yanqin Jin 9586dcf1ce Expose the initial logger creation error (#10223) ... Summary: https://github.com/facebook/rocksdb/issues/9984 changes the behavior of RocksDB: if logger creation failed during `SanitizeOptions()`, `DB::Open()` will fail. However, since `SanitizeOptions()` is called in `DBImpl::DBImpl()`, we cannot directly expose the error to caller without some additional work. This is a first version proposal which: - Adds a new member `init_logger_creation_s` to `DBImpl` to store the result of init logger creation - Checks the error during `DB::Open()` and return it to caller if non-ok This is not very ideal. We can alternatively move the logger creation logic out of the `SanitizeOptions()`. Since `SanitizeOptions()` is used in other places, we need to check whether this change breaks anything in case other callers of `SanitizeOptions()` assumes that a logger should be created. Pull Request resolved: https://github.com/facebook/rocksdb/pull/10223 Test Plan: make check Reviewed By: pdillinger Differential Revision: D37321717 Pulled By: riversand963 fbshipit-source-id: 58042358a86369d606549dd9938933dd47591c4b		2 years ago
..
compacted_db_impl.cc	Return "invalid argument" when read timestamp is too old (#10109)	2 years ago
compacted_db_impl.h	Add timestamp support to CompactedDBImpl (#10030)	3 years ago
db_impl.cc	Expose the initial logger creation error (#10223)	2 years ago
db_impl.h	Expose the initial logger creation error (#10223)	2 years ago
db_impl_compaction_flush.cc	Add basic kRoundRobin compaction policy (#10107)	2 years ago
db_impl_debug.cc	Use std::numeric_limits<> (#9954)	3 years ago
db_impl_experimental.cc	Track SST unique id in MANIFEST and verify (#9990)	3 years ago
db_impl_files.cc	Fix race condition with WAL tracking and `FlushWAL(true /* sync */)` (#10185)	2 years ago
db_impl_open.cc	Expose the initial logger creation error (#10223)	2 years ago
db_impl_readonly.cc	Return "invalid argument" when read timestamp is too old (#10109)	2 years ago
db_impl_readonly.h	Add timestamp support to DBImplReadOnly (#10004)	3 years ago
db_impl_secondary.cc	Consolidate manual_compaction_paused_ check (#10070)	2 years ago
db_impl_secondary.h	Persist the new MANIFEST after successfully syncing the new WAL during recovery (#9922)	3 years ago
db_impl_write.cc	Fix race condition with WAL tracking and `FlushWAL(true /* sync */)` (#10185)	2 years ago