You can not select more than 25 topics
Topics must start with a letter or number, can include dashes ('-') and can be up to 35 characters long.
Ramkumar Vadivelu
9a690a74e1
In ParseInternalKey(), include corrupt key info in Status ( #7515 )
...
Summary:
Fixes Issue https://github.com/facebook/rocksdb/issues/7497
When allow_data_in_errors db_options is set, log error key details in `ParseInternalKey()`
Have fixed most of the calls. Have few TODOs still pending - because have to make more deeper changes to pass in the allow_data_in_errors flag. Will do those in a separate PR later.
Tests:
- make check
- some of the existing tests that exercise the "internal key too small" condition are: dbformat_test, cuckoo_table_builder_test
- some of the existing tests that exercise the corrupted key path are: corruption_test, merge_helper_test, compaction_iterator_test
Example of new status returns:
- Key too small - `Corrupted Key: Internal Key too small. Size=5`
- Corrupt key with allow_data_in_errors option set to false: `Corrupted Key: '<redacted>' seq:3, type:3`
- Corrupt key with allow_data_in_errors option set to true: `Corrupted Key: '61' seq:3, type:3`
Pull Request resolved: https://github.com/facebook/rocksdb/pull/7515
Reviewed By: ajkr
Differential Revision: D24240264
Pulled By: ramvadiv
fbshipit-source-id: bc48f5d4475ac19d7713e16df37505b31aac42e7
4 years ago
..
advisor
remediation of S205607
4 years ago
block_cache_analyzer
In ParseInternalKey(), include corrupt key info in Status ( #7515 )
4 years ago
dump
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
rdb
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
CMakeLists.txt
Mark dependencies as PRIVATE and fix missing dependencies in tools. ( #6790 )
5 years ago
Dockerfile
adding docker build script and dockerfile
10 years ago
analyze_txn_stress_test.sh
Add copyright headers per FB open-source checkup tool. ( #5199 )
6 years ago
auto_sanity_test.sh
Add copyright headers per FB open-source checkup tool. ( #5199 )
6 years ago
benchmark.sh
Fixed typo in benchmark.sh ( #6434 )
5 years ago
benchmark_leveldb.sh
Add copyright headers per FB open-source checkup tool. ( #5199 )
6 years ago
blob_dump.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
check_all_python.py
Allow missing "unversioned" python, as in CentOS 8 ( #6883 )
5 years ago
check_format_compatible.sh
Fix HISTORY.md and check_format_compatible.sh for 6.13 branch ( #7401 )
4 years ago
db_bench.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
db_bench_tool.cc
Introduce a helper method UncompressData ( #7434 )
4 years ago
db_bench_tool_test.cc
Fix db_bench_tool_test. Fixes 7341 ( #7344 )
4 years ago
db_crashtest.py
db_crashtest preserves expected values file for failed crash tests ( #7534 )
4 years ago
db_repl_stress.cc
More Makefile Cleanup ( #7097 )
5 years ago
db_sanity_test.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
dbench_monitor
Fix /bin/bash shebangs
7 years ago
generate_random_db.sh
Add copyright headers per FB open-source checkup tool. ( #5199 )
6 years ago
ingest_external_sst.sh
Add copyright headers per FB open-source checkup tool. ( #5199 )
6 years ago
io_tracer_parser.cc
Add IO Tracer Parser ( #7333 )
4 years ago
io_tracer_parser_test.cc
Add IO Tracer Parser ( #7333 )
4 years ago
io_tracer_parser_tool.cc
Add IO Tracer Parser ( #7333 )
4 years ago
io_tracer_parser_tool.h
Add IO Tracer Parser ( #7333 )
4 years ago
ldb.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
ldb_cmd.cc
Make FileType Public and Replace kLogFile with kWalFile ( #7580 )
4 years ago
ldb_cmd_impl.h
add `ldb unsafe_remove_sst_file` subcommand ( #7335 )
4 years ago
ldb_cmd_test.cc
Store FileSystemPtr object that contains FileSystem ptr ( #7180 )
4 years ago
ldb_test.py
Allow missing "unversioned" python, as in CentOS 8 ( #6883 )
5 years ago
ldb_tool.cc
add `ldb unsafe_remove_sst_file` subcommand ( #7335 )
4 years ago
pflag
Fix /bin/bash shebangs
7 years ago
reduce_levels_test.cc
Replace reinterpret_cast with static_cast_with_check ( #7067 )
5 years ago
regression_test.sh
Add copyright headers per FB open-source checkup tool. ( #5199 )
6 years ago
report_lite_binary_size.sh
Add copyright headers per FB open-source checkup tool. ( #5199 )
6 years ago
rocksdb_dump_test.sh
Add copyright headers per FB open-source checkup tool. ( #5199 )
6 years ago
run_flash_bench.sh
Add copyright headers per FB open-source checkup tool. ( #5199 )
6 years ago
run_leveldb.sh
Add copyright headers per FB open-source checkup tool. ( #5199 )
6 years ago
sample-dump.dmp
First version of rocksdb_dump and rocksdb_undump.
10 years ago
sst_dump.cc
Implement a new subcommand "identify" for sst_dump ( #6943 )
5 years ago
sst_dump_test.cc
Fix compile error for old gcc-4.8 ( #7358 )
4 years ago
sst_dump_tool.cc
In ParseInternalKey(), include corrupt key info in Status ( #7515 )
4 years ago
trace_analyzer.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
trace_analyzer_test.cc
Add trace_analyzer_test to ASSERT_STATUS_CHECKED list ( #7480 )
4 years ago
trace_analyzer_tool.cc
Add trace_analyzer_test to ASSERT_STATUS_CHECKED list ( #7480 )
4 years ago
trace_analyzer_tool.h
Add trace_analyzer_test to ASSERT_STATUS_CHECKED list ( #7480 )
4 years ago
verify_random_db.sh
Add copyright headers per FB open-source checkup tool. ( #5199 )
6 years ago
write_external_sst.sh
Add copyright headers per FB open-source checkup tool. ( #5199 )
6 years ago
write_stress.cc
Replace namespace name "rocksdb" with ROCKSDB_NAMESPACE ( #6433 )
5 years ago
write_stress_runner.py
Allow missing "unversioned" python, as in CentOS 8 ( #6883 )
5 years ago